From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q6CMwu5A088198 for ; Thu, 12 Jul 2012 17:58:56 -0500 Date: Thu, 12 Jul 2012 18:04:21 -0500 From: Ben Myers Subject: Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks Message-ID: <20120712230421.GE29979@sgi.com> References: <20120702100003.960640484@bombadil.infradead.org> <20120702100034.921366796@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120702100034.921366796@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com SGV5IENocmlzdG9waCwKCk9uIE1vbiwgSnVsIDAyLCAyMDEyIGF0IDA2OjAwOjA1QU0gLTA0MDAs IENocmlzdG9waCBIZWxsd2lnIHdyb3RlOgo+IHhmc19iZHN0cmF0X2NiIG9ubHkgYWRkcyBhIGNo ZWNrIGZvciBhIHNodXRkb3duIGZpbGVzeXN0ZW0gb3ZlciB4ZnNfYnVmX2lvcmVxdWVzdCwKPiBi dXQgeGZzX2J1Zl9pb2RvbmVfY2FsbGJhY2tzIGp1c3QgY2hlY2tlZCBmb3IgYSBzaHV0IGRvd24g ZmlsZXN5c3RlbSBhIGxpdHRsZQo+IGVhcmxpZXIuICBJbiBhZGRpdGlvbiB0aGUgc2h1dGRvd24g aGFuZGxpbmcgaW4geGZzX2Jkc3RyYXRfY2IgaXMgbm90IHZlcnkgc3VpdGFibGUKPiBmb3IgdGhp cyBjYWxsZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3Qu ZGU+Cj4gCj4gLS0tCj4gIGZzL3hmcy94ZnNfYnVmLmMgICAgICB8ICAgNTEgKysrKysrKysrKysr KysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZnMveGZzL3hmc19idWZf aXRlbS5jIHwgICAgMiAtCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMzAg ZGVsZXRpb25zKC0pCj4gCj4gSW5kZXg6IHhmcy9mcy94ZnMveGZzX2J1Zl9pdGVtLmMKPiA9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Cj4gLS0tIHhmcy5vcmlnL2ZzL3hmcy94ZnNfYnVmX2l0ZW0uYwkyMDEyLTA2LTI2IDIz OjIwOjIyLjMyNjQwNzM4NyArMDIwMAo+ICsrKyB4ZnMvZnMveGZzL3hmc19idWZfaXRlbS5jCTIw MTItMDYtMjYgMjM6MjA6MjguNzY2NDA3MzQ5ICswMjAwCj4gQEAgLTk1NCw3ICs5NTQsNyBAQCB4 ZnNfYnVmX2lvZG9uZV9jYWxsYmFja3MoCj4gIAo+ICAJCWlmICghWEZTX0JVRl9JU1NUQUxFKGJw KSkgewo+ICAJCQlicC0+Yl9mbGFncyB8PSBYQkZfV1JJVEUgfCBYQkZfQVNZTkMgfCBYQkZfRE9O RTsKPiAtCQkJeGZzX2Jkc3RyYXRfY2IoYnApOwo+ICsJCQl4ZnNfYnVmX2lvcmVxdWVzdChicCk7 Cj4gIAkJfSBlbHNlIHsKPiAgCQkJeGZzX2J1Zl9yZWxzZShicCk7Cj4gIAkJfQo+IEluZGV4OiB4 ZnMvZnMveGZzL3hmc19idWYuYwo+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KPiAtLS0geGZzLm9yaWcvZnMveGZzL3hm c19idWYuYwkyMDEyLTA2LTI2IDIzOjIwOjIzLjY4NjQwNzM3OSArMDIwMAo+ICsrKyB4ZnMvZnMv eGZzL3hmc19idWYuYwkyMDEyLTA2LTI2IDIzOjIxOjQwLjI4NjQwNjkyNCArMDIwMAo+IEBAIC05 ODksMjcgKzk4OSw2IEBAIHhmc19idWZfaW9lcnJvcl9hbGVydCgKPiAgCQkoX191aW50NjRfdClY RlNfQlVGX0FERFIoYnApLCBmdW5jLCBicC0+Yl9lcnJvciwgYnAtPmJfbGVuZ3RoKTsKPiAgfQo+ ICAKPiAtaW50Cj4gLXhmc19id3JpdGUoCj4gLQlzdHJ1Y3QgeGZzX2J1ZgkJKmJwKQo+IC17Cj4g LQlpbnQJCQllcnJvcjsKPiAtCj4gLQlBU1NFUlQoeGZzX2J1Zl9pc2xvY2tlZChicCkpOwo+IC0K PiAtCWJwLT5iX2ZsYWdzIHw9IFhCRl9XUklURTsKPiAtCWJwLT5iX2ZsYWdzICY9IH4oWEJGX0FT WU5DIHwgWEJGX1JFQUQgfCBfWEJGX0RFTFdSSV9RKTsKPiAtCj4gLQl4ZnNfYmRzdHJhdF9jYihi cCk7Cj4gLQo+IC0JZXJyb3IgPSB4ZnNfYnVmX2lvd2FpdChicCk7Cj4gLQlpZiAoZXJyb3IpIHsK PiAtCQl4ZnNfZm9yY2Vfc2h1dGRvd24oYnAtPmJfdGFyZ2V0LT5idF9tb3VudCwKPiAtCQkJCSAg IFNIVVRET1dOX01FVEFfSU9fRVJST1IpOwo+IC0JfQo+IC0JcmV0dXJuIGVycm9yOwo+IC19Cj4g LQo+ICAvKgo+ICAgKiBDYWxsZWQgd2hlbiB3ZSB3YW50IHRvIHN0b3AgYSBidWZmZXIgZnJvbSBn ZXR0aW5nIHdyaXR0ZW4gb3IgcmVhZC4KPiAgICogV2UgYXR0YWNoIHRoZSBFSU8gZXJyb3IsIG11 Y2sgd2l0aCBpdHMgZmxhZ3MsIGFuZCBjYWxsIHhmc19idWZfaW9lbmQKPiBAQCAtMTA3OSwxNCAr MTA1OCw3IEBAIHhmc19iaW9lcnJvcl9yZWxzZSgKPiAgCXJldHVybiBFSU87Cj4gIH0KPiAgCj4g LQo+IC0vKgo+IC0gKiBBbGwgeGZzIG1ldGFkYXRhIGJ1ZmZlcnMgZXhjZXB0IGxvZyBzdGF0ZSBt YWNoaW5lIGJ1ZmZlcnMKPiAtICogZ2V0IHRoaXMgYXR0YWNoZWQgYXMgdGhlaXIgYl9iZHN0cmF0 IGNhbGxiYWNrIGZ1bmN0aW9uLgo+IC0gKiBUaGlzIGlzIHNvIHRoYXQgd2UgY2FuIGNhdGNoIGEg YnVmZmVyCj4gLSAqIGFmdGVyIHByZW1hdHVyZWx5IHVucGlubmluZyBpdCB0byBmb3JjaWJseSBz aHV0ZG93biB0aGUgZmlsZXN5c3RlbS4KPiAtICovCj4gLWludAo+ICtTVEFUSUMgaW50Cgp4ZnMv ZnMveGZzL3hmc19idWYuYzoxMDYyOiBlcnJvcjogc3RhdGljIGRlY2xhcmF0aW9uIG9mIOKAmHhm c19iZHN0cmF0X2Ni4oCZIGZvbGxvd3Mgbm9uLXN0YXRpYyBkZWNsYXJhdGlvbgp4ZnMvZnMveGZz L3hmc19idWYuaDoxODM6IGVycm9yOiBwcmV2aW91cyBkZWNsYXJhdGlvbiBvZiDigJh4ZnNfYmRz dHJhdF9jYuKAmSB3YXMgaGVyZQoKQ09ORklHX1hGU19ERUJVRyB3YXMgbm90IHNldC4KCkknbSBo YXBweSB0byBoYXZlIGNhdWdodCB0aGF0IGJlZm9yZSBwdWxsaW5nIHRoaXMgaW4uICBNb3N0IG9m IHRoZSB0aW1lIEkgYW0KdGVzdGluZyB3aXRoIENPTkZJR19YRlNfREVCVUc9eS4gIEknbGwgZml4 IGl0IHVwLgoKUmVnYXJkcywKCUJlbgoKPiAgeGZzX2Jkc3RyYXRfY2IoCj4gIAlzdHJ1Y3QgeGZz X2J1ZgkqYnApCj4gIHsKPiBAQCAtMTEwNyw2ICsxMDc5LDI3IEBAIHhmc19iZHN0cmF0X2NiKAo+ ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK2ludAo+ICt4ZnNfYndyaXRlKAo+ICsJc3RydWN0IHhm c19idWYJCSpicCkKPiArewo+ICsJaW50CQkJZXJyb3I7Cj4gKwo+ICsJQVNTRVJUKHhmc19idWZf aXNsb2NrZWQoYnApKTsKPiArCj4gKwlicC0+Yl9mbGFncyB8PSBYQkZfV1JJVEU7Cj4gKwlicC0+ Yl9mbGFncyAmPSB+KFhCRl9BU1lOQyB8IFhCRl9SRUFEIHwgX1hCRl9ERUxXUklfUSk7Cj4gKwo+ ICsJeGZzX2Jkc3RyYXRfY2IoYnApOwo+ICsKPiArCWVycm9yID0geGZzX2J1Zl9pb3dhaXQoYnAp Owo+ICsJaWYgKGVycm9yKSB7Cj4gKwkJeGZzX2ZvcmNlX3NodXRkb3duKGJwLT5iX3RhcmdldC0+ YnRfbW91bnQsCj4gKwkJCQkgICBTSFVURE9XTl9NRVRBX0lPX0VSUk9SKTsKPiArCX0KPiArCXJl dHVybiBlcnJvcjsKPiArfQo+ICsKPiAgLyoKPiAgICogV3JhcHBlciBhcm91bmQgYmRzdHJhdCBz byB0aGF0IHdlIGNhbiBzdG9wIGRhdGEgZnJvbSBnb2luZyB0byBkaXNrIGluIGNhc2UKPiAgICog d2UgYXJlIHNodXR0aW5nIGRvd24gdGhlIGZpbGVzeXN0ZW0uICBUeXBpY2FsbHkgdXNlciBkYXRh IGdvZXMgdGhydSB0aGlzCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiB4ZnMgbWFpbGluZyBsaXN0Cj4geGZzQG9zcy5zZ2kuY29tCj4gaHR0cDov L29zcy5zZ2kuY29tL21haWxtYW4vbGlzdGluZm8veGZzCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwp4ZnMgbWFpbGluZyBsaXN0Cnhmc0Bvc3Muc2dpLmNv bQpodHRwOi8vb3NzLnNnaS5jb20vbWFpbG1hbi9saXN0aW5mby94ZnMK