All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@linux.intel.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: rcu_dyntick and suspicious RCU usage
Date: Fri, 13 Jul 2012 17:12:30 +0800	[thread overview]
Message-ID: <20120713091230.GA20208@localhost> (raw)
In-Reply-To: <20120712170242.GB31396@linux.vnet.ibm.com>

On Thu, Jul 12, 2012 at 10:02:42AM -0700, Paul E. McKenney wrote:
> On Fri, Jul 13, 2012 at 12:57:38AM +0800, Fengguang Wu wrote:
> > On Thu, Jul 12, 2012 at 09:43:08AM -0700, Paul E. McKenney wrote:
> > > On Wed, Jul 11, 2012 at 12:49:24AM -0700, Paul E. McKenney wrote:
> > > > On Tue, Jul 10, 2012 at 12:47:00PM +0800, Fengguang Wu wrote:
> > > > > Hi Paul,
> > > > > 
> > > > > Fortunately this bug is bisectable and the first bad commit is:
> > > > > 
> > > > >         commit 9b2e4f1880b789be1f24f9684f7a54b90310b5c0
> > > > >         Author: Paul E. McKenney <paul.mckenney@linaro.org>
> > > > >         Date:   Fri Sep 30 12:10:22 2011 -0700
> > > > > 
> > > > >             rcu: Track idleness independent of idle tasks
> > > > 
> > > > OK, there is a problem in TINY_RCU's handling of dyntick-idle: it
> > > > traces while in idle.  The confusion on my part was that in TREE_RCU,
> > > > the nesting and dyntick-idle indication are different, while in
> > > > TINY_RCU they are one and the same.
> > > > 
> > > > Does the following patch help?
> > > 
> > > This one failed in my testing.  Please see the end for the fixed
> > > version, with on small but important change.
> > 
> > It worked, thanks!
> > 
> > Tested-by: Fengguang Wu <wfg@linux.intel.com>
> 
> Very good!  (And please ignore my resend of the same patch.)
> 
> I will queue this.

Will you recommend it for -stable? It impacts 3.3/3.4. I tested it on
3.4 and it works fine. However for 3.3, the patch cannot apply cleanly.

Thanks,
Fengguang

  reply	other threads:[~2012-07-13  9:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 13:56 rcu_dyntick and suspicious RCU usage wfg
2012-07-09 14:57 ` Fengguang Wu
2012-07-10  4:47   ` Fengguang Wu
2012-07-11  7:49     ` Paul E. McKenney
2012-07-11 12:36       ` Fengguang Wu
2012-07-11 12:55         ` Fengguang Wu
2012-07-12 14:11           ` Fengguang Wu
2012-07-12 17:01             ` Paul E. McKenney
2012-07-12 16:43       ` Paul E. McKenney
2012-07-12 16:57         ` Fengguang Wu
2012-07-12 17:02           ` Paul E. McKenney
2012-07-13  9:12             ` Fengguang Wu [this message]
2012-07-17 20:58               ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120713091230.GA20208@localhost \
    --to=wfg@linux.intel.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.