From: Arnd Bergmann <arnd@arndb.de>
To: Devendra Naga <develkernel412222@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/BSR: cleanup the error path of bsr_init
Date: Sun, 15 Jul 2012 19:52:17 +0000 [thread overview]
Message-ID: <201207151952.17634.arnd@arndb.de> (raw)
In-Reply-To: <1342358522-10956-1-git-send-email-develkernel412222@gmail.com>
On Sunday 15 July 2012, Devendra Naga wrote:
> class_create if succeeded returns a pointer to the struct class,
> and if it fails, it returns a value enclosed by the pointer, which
> can be read by using PTR_ERR.
>
> Handle the error and return it.
>
> result is for error checking of the alloc_chrdev_region, instead
> ret can be used, and also if the alloc_chrdev_region fail,
> we are still returning -ENODEV, use ret and the error path will
> take care of returning of the ret.
>
> Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2012-07-15 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 13:22 [PATCH] powerpc/BSR: cleanup the error path of bsr_init Devendra Naga
2012-07-15 19:52 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207151952.17634.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=develkernel412222@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.