From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752740Ab2GPPGU (ORCPT ); Mon, 16 Jul 2012 11:06:20 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:45440 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432Ab2GPPGQ (ORCPT ); Mon, 16 Jul 2012 11:06:16 -0400 Date: Mon, 16 Jul 2012 10:57:29 -0400 From: Konrad Rzeszutek Wilk To: Ian Campbell Cc: Stefano Stabellini , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xensource.com" , "Tim (Xen.org)" Subject: Re: [PATCH WIP 1/6] xen/arm: fix the shared_info and vcpu_info structs Message-ID: <20120716145729.GC552@phenom.dumpdata.com> References: <1340381685-22529-1-git-send-email-stefano.stabellini@eu.citrix.com> <20120709144156.GC12102@phenom.dumpdata.com> <1342199338.8586.221.camel@hastur.hellion.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1342199338.8586.221.camel@hastur.hellion.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 13, 2012 at 11:08:58AM -0600, Ian Campbell wrote: > On Fri, 2012-07-13 at 12:48 -0400, Stefano Stabellini wrote: > > On Mon, 9 Jul 2012, Konrad Rzeszutek Wilk wrote: > > > On Fri, Jun 22, 2012 at 05:14:40PM +0100, Stefano Stabellini wrote: > > > > Fix the shared_info and vcpu_info struct definitions to match the ones > > > > in Xen. > > > > > > Is there a corresponding c/s in the Xen tree for this? > > > > That's the problem: arch_vcpu_info and arch_shared_info haven't been > > defined in Xen yet on ARM. > > Strictly speaking they are defined (in xen/include/public/arch-arm.h), > they are just empty ;-) > > > I think the ones below have been copied from xen/x86 by mistake. > > Yes, it does look that way. Ah, pls mention that in the git commit description. > > > > > > > > > > > > > Signed-off-by: Stefano Stabellini > > > > --- > > > > arch/arm/include/asm/xen/interface.h | 15 +++------------ > > > > 1 files changed, 3 insertions(+), 12 deletions(-) > > > > > > > > diff --git a/arch/arm/include/asm/xen/interface.h b/arch/arm/include/asm/xen/interface.h > > > > index 3ad2d4b..8ab7cebb 100644 > > > > --- a/arch/arm/include/asm/xen/interface.h > > > > +++ b/arch/arm/include/asm/xen/interface.h > > > > @@ -40,19 +40,10 @@ DEFINE_GUEST_HANDLE(xen_pfn_t); > > > > #endif > > > > > > > > /* Maximum number of virtual CPUs in multi-processor guests. */ > > > > -#define MAX_VIRT_CPUS 32 > > > > +#define MAX_VIRT_CPUS 1 > > > > > > > > -struct arch_vcpu_info { > > > > - unsigned long cr2; > > > > - unsigned long pad; /* sizeof(vcpu_info_t) == 64 */ > > > > -}; > > > > - > > > > -struct arch_shared_info { > > > > - unsigned long max_pfn; /* max pfn that appears in table */ > > > > - /* Frame containing list of mfns containing list of mfns containing p2m. */ > > > > - unsigned long pfn_to_mfn_frame_list_list; > > > > - unsigned long nmi_reason; > > > > -}; > > > > +struct arch_vcpu_info { }; > > > > +struct arch_shared_info { }; > > > > > > > > /* XXX: Move pvclock definitions some place arch independent */ > > > > struct pvclock_vcpu_time_info { > > > > -- > > > > 1.7.2.5 > > > > > > > > -- > > > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > > > the body of a message to majordomo@vger.kernel.org > > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > Please read the FAQ at http://www.tux.org/lkml/ > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/