From: David Miller <davem@davemloft.net>
To: David.Laight@ACULAB.COM
Cc: rick.jones2@hp.com, cascardo@linux.vnet.ibm.com,
netdev@vger.kernel.org, yevgenyp@mellanox.co.il,
ogerlitz@mellanox.com, amirv@mellanox.com,
brking@linux.vnet.ibm.com, leitao@linux.vnet.ibm.com,
klebers@linux.vnet.ibm.com
Subject: Re: [PATCH] mlx4_en: map entire pages to increase throughput
Date: Tue, 17 Jul 2012 06:46:33 -0700 (PDT) [thread overview]
Message-ID: <20120717.064633.1533728304261811367.davem@davemloft.net> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6F8D@saturn3.aculab.com>
From: "David Laight" <David.Laight@ACULAB.COM>
Date: Tue, 17 Jul 2012 14:36:11 +0100
> The driver will already have to cope with 'too many segments'
> (I remember being passed a full sized frame made of a list
> of 1-byte message blocks...)
Baring driver hardware bug workarounds, no it does not have to cope
with that. The code is extremely simple now.
All the driver has to do is assume that a new TX packet can never
consume more than MAX_SKB_FRAGS.
Therefore it simply stops the queue if less than MAX_SKB_FRAGS
segments remain after queueing a transmit.
Your suggestion will significantly complicate driver TX paths.
If you're going to suggest a solution, it has to be completely
general enough to work in the current state of affairs, and
your idea absolutely does not.
next prev parent reply other threads:[~2012-07-17 13:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 17:01 [PATCH] mlx4_en: map entire pages to increase throughput Thadeu Lima de Souza Cascardo
2012-07-16 17:27 ` Rick Jones
2012-07-16 19:06 ` Thadeu Lima de Souza Cascardo
2012-07-16 19:06 ` Thadeu Lima de Souza Cascardo
2012-07-16 19:42 ` Rick Jones
2012-07-16 19:42 ` Rick Jones
2012-07-16 20:36 ` Or Gerlitz
2012-07-16 20:36 ` Or Gerlitz
2012-07-16 20:43 ` Or Gerlitz
2012-07-16 20:43 ` Or Gerlitz
2012-07-16 20:57 ` Thadeu Lima de Souza Cascardo
2012-07-16 20:57 ` Thadeu Lima de Souza Cascardo
2012-07-18 14:59 ` Or Gerlitz
2012-07-18 14:59 ` Or Gerlitz
2012-07-16 20:47 ` Thadeu Lima de Souza Cascardo
2012-07-16 20:47 ` Thadeu Lima de Souza Cascardo
2012-07-16 21:08 ` Rick Jones
2012-07-16 21:08 ` Rick Jones
2012-07-17 5:29 ` David Miller
2012-07-17 12:42 ` David Laight
2012-07-17 12:50 ` David Miller
2012-07-17 13:36 ` David Laight
2012-07-17 13:46 ` David Miller [this message]
2012-07-17 13:50 ` Eric Dumazet
2012-07-17 18:17 ` Rick Jones
2012-07-17 20:10 ` Brian King
2012-07-17 20:20 ` David Miller
2012-07-19 17:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717.064633.1533728304261811367.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=amirv@mellanox.com \
--cc=brking@linux.vnet.ibm.com \
--cc=cascardo@linux.vnet.ibm.com \
--cc=klebers@linux.vnet.ibm.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=rick.jones2@hp.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.