All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ja@ssi.bg
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/5] Long term PMTU/redirect storage in ipv4.
Date: Tue, 17 Jul 2012 13:46:51 -0700 (PDT)	[thread overview]
Message-ID: <20120717.134651.562831385960975623.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1207172249270.1831@ja.ssi.bg>

From: Julian Anastasov <ja@ssi.bg>
Date: Tue, 17 Jul 2012 23:41:16 +0300 (EEST)

> 	IIRC, struct fib_info was shared by different
> prefixes. It saves a lot of memory when thousands of
> routes are created to same GW. Now if we end up with 1 or
> 2 fib_info structures for default routes, the nh_exceptions list
> can become very long. May be fib_info is not a good place
> to hide such data.

Your analysis of what fib_info is and how it's intended to
work is accurate.

But we don't use a linked list for the exceptions in the final
version, we use a reclaiming RCU'd hash table like we use for TCP
metrics.

See the updated version of patch #5 and what I actually committed to
net-next.

  reply	other threads:[~2012-07-17 20:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 13:14 [PATCH 0/5] Long term PMTU/redirect storage in ipv4 David Miller
2012-07-17 18:03 ` David Miller
2012-07-18  4:58   ` net-next and IPv6 Eric Dumazet
2012-07-18  7:04     ` Eric Dumazet
2012-07-18  7:23       ` Eric Dumazet
2012-07-18  7:38         ` [PATCH net-next] ipv6: fix inet6_csk_xmit() Eric Dumazet
2012-07-18 16:00           ` David Miller
2012-07-17 20:41 ` [PATCH 0/5] Long term PMTU/redirect storage in ipv4 Julian Anastasov
2012-07-17 20:46   ` David Miller [this message]
2012-07-17 22:14     ` Julian Anastasov
2012-07-17 22:09       ` David Miller
2012-07-18  1:06         ` Julian Anastasov
2012-07-18  3:46           ` Eric Dumazet
2012-07-18  7:28             ` Julian Anastasov
2012-07-18  7:30               ` Eric Dumazet
2012-07-18  8:36                 ` Julian Anastasov
2012-07-18 16:07                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120717.134651.562831385960975623.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ja@ssi.bg \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.