From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2 1/2] pinctrl: pinctrl-imx: add support for set bits for general purpose registers Date: Tue, 17 Jul 2012 19:24:34 +0100 Message-ID: <20120717182434.GB11723@sirena.org.uk> References: <1342084080-3145-1-git-send-email-b29396@freescale.com> <20120717030225.GF19699@shlinux2.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Linus Walleij Cc: Zhao Richard-B20223 , "linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Liu Hui-R64343 , "kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , Mike Turquette , "s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Samuel Ortiz List-Id: devicetree@vger.kernel.org On Tue, Jul 17, 2012 at 08:15:40PM +0200, Linus Walleij wrote: > u32 db8500_prcmu_read(unsigned int reg); > void db8500_prcmu_write(unsigned int reg, u32 value); > void db8500_prcmu_write_masked(unsigned int reg, u32 mask, u32 value); > The third function is an oddity which performs read-modify-write > on the other side (firmware). Not so odd - a very high proportion of APIs like this have a r/m/w operation as there's usually a requirement for doing the updates atomically. From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Tue, 17 Jul 2012 19:24:34 +0100 Subject: [PATCH v2 1/2] pinctrl: pinctrl-imx: add support for set bits for general purpose registers In-Reply-To: References: <1342084080-3145-1-git-send-email-b29396@freescale.com> <20120717030225.GF19699@shlinux2.ap.freescale.net> Message-ID: <20120717182434.GB11723@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 17, 2012 at 08:15:40PM +0200, Linus Walleij wrote: > u32 db8500_prcmu_read(unsigned int reg); > void db8500_prcmu_write(unsigned int reg, u32 value); > void db8500_prcmu_write_masked(unsigned int reg, u32 mask, u32 value); > The third function is an oddity which performs read-modify-write > on the other side (firmware). Not so odd - a very high proportion of APIs like this have a r/m/w operation as there's usually a requirement for doing the updates atomically.