From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default Date: Wed, 18 Jul 2012 00:10:39 -0700 Message-ID: <20120718071039.GI6522@atomide.com> References: <1342485005-5178-1-git-send-email-javier@dowhile0.org> <20120718065951.GH6522@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org To: "Shilimkar, Santosh" Cc: Javier Martinez Canillas , Kevin.Hilman.khilman@ti.com, Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Ball , linux-mmc@vger.kernel.org List-Id: linux-mmc@vger.kernel.org * Shilimkar, Santosh [120718 00:09]: > On Wed, Jul 18, 2012 at 12:29 PM, Tony Lindgren wrote: > > * Javier Martinez Canillas [120716 23:56]: > >> On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh > >> wrote: > >> > Hi, > >> > > >> > On Tue, Jul 17, 2012 at 6:00 AM, Javier Martinez Canillas > >> > wrote: > >> >> The OMAP MMC and OMAP High Speed MMC hosts now use entirely the DMA > >> >> engine API instead of the previous private DMA API implementation. > >> >> > >> >> So, if the kernel is built with support for any of these hosts but it > >> >> doesn't support DMA devices nor OMAP DMA support, it fails when trying > >> >> to obtain a DMA channel which leads to the following error on an OMAP3 > >> >> IGEPv2 Rev.C board (and probably on most OMAP boards with MMC support): > >> >> > >> >> [ 2.199981] omap_hsmmc omap_hsmmc.1: unable to obtain RX DMA engine channel 48 > >> >> [ 2.215087] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62 > >> >> > >> >> selecting automatically CONFIG_DMADEVICES and CONFIG_DMA_OMAP solves it. > >> >> > >> >> Signed-off-by: Javier Martinez Canillas > >> >> --- > >> > Considering, we are updating drivers to select the DMA engine, can you > >> > also include > >> > "drivers/spi/spi-omap2-mcspi.c" which is also updated for DMA engine. > >> > > >> > Regards > >> > Santosh > >> > >> Hi Santosh, > >> > >> Ok, I'll send a v2 now which includes spi-omap2-mcspi then. > > > > I don't think we should do this, the drivers should work with and without > > dma. This just needs to be added to the omap2plus_defconfig. > > > Well this was not decided based on any DMA CONFIG option before for > the subject drivers. It is already by default enabled if the DMA is supported > by the driver IP. There is a possibility to disable it from driver platform/dt > data so that still remains. I think it should rather be that if the driver is broken and does not work without DMA, it should have depends on CONFIG_DMA_OMAP. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 18 Jul 2012 00:10:39 -0700 Subject: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default In-Reply-To: References: <1342485005-5178-1-git-send-email-javier@dowhile0.org> <20120718065951.GH6522@atomide.com> Message-ID: <20120718071039.GI6522@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Shilimkar, Santosh [120718 00:09]: > On Wed, Jul 18, 2012 at 12:29 PM, Tony Lindgren wrote: > > * Javier Martinez Canillas [120716 23:56]: > >> On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh > >> wrote: > >> > Hi, > >> > > >> > On Tue, Jul 17, 2012 at 6:00 AM, Javier Martinez Canillas > >> > wrote: > >> >> The OMAP MMC and OMAP High Speed MMC hosts now use entirely the DMA > >> >> engine API instead of the previous private DMA API implementation. > >> >> > >> >> So, if the kernel is built with support for any of these hosts but it > >> >> doesn't support DMA devices nor OMAP DMA support, it fails when trying > >> >> to obtain a DMA channel which leads to the following error on an OMAP3 > >> >> IGEPv2 Rev.C board (and probably on most OMAP boards with MMC support): > >> >> > >> >> [ 2.199981] omap_hsmmc omap_hsmmc.1: unable to obtain RX DMA engine channel 48 > >> >> [ 2.215087] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62 > >> >> > >> >> selecting automatically CONFIG_DMADEVICES and CONFIG_DMA_OMAP solves it. > >> >> > >> >> Signed-off-by: Javier Martinez Canillas > >> >> --- > >> > Considering, we are updating drivers to select the DMA engine, can you > >> > also include > >> > "drivers/spi/spi-omap2-mcspi.c" which is also updated for DMA engine. > >> > > >> > Regards > >> > Santosh > >> > >> Hi Santosh, > >> > >> Ok, I'll send a v2 now which includes spi-omap2-mcspi then. > > > > I don't think we should do this, the drivers should work with and without > > dma. This just needs to be added to the omap2plus_defconfig. > > > Well this was not decided based on any DMA CONFIG option before for > the subject drivers. It is already by default enabled if the DMA is supported > by the driver IP. There is a possibility to disable it from driver platform/dt > data so that still remains. I think it should rather be that if the driver is broken and does not work without DMA, it should have depends on CONFIG_DMA_OMAP. Regards, Tony