From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926Ab2GRJXJ (ORCPT ); Wed, 18 Jul 2012 05:23:09 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:35651 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779Ab2GRJXB (ORCPT ); Wed, 18 Jul 2012 05:23:01 -0400 Date: Wed, 18 Jul 2012 14:52:52 +0530 From: Srikar Dronamraju To: Jovi Zhang Cc: Steven Rostedt , Fr?d?ric Weisbecker , LKML Subject: Re: [PATCH] uprobe: fix misleading log entry Message-ID: <20120718092252.GD5006@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12071809-4242-0000-0000-0000025D6D05 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jovi Zhang [2012-07-18 11:08:42]: > From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001 > From: Jovi Zhang > Date: Wed, 18 Jul 2012 17:51:26 +0800 > Subject: [PATCH] uprobe: fix misleading log entry > > There don't have any 'r' prefix in uprobe event naming, remove it. > > Signed-off-by: Jovi Zhang > --- > kernel/trace/trace_uprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index cf382de..852a584 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv) > if (argv[0][0] == '-') > is_delete = true; > else if (argv[0][0] != 'p') { > - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n"); > + pr_info("Probe definition must be started with 'p' or '-'.\n"); > return -EINVAL; > } > Yes, uprobes doesnt support return probes. So we should not have mentioned about r. Acked-by: Srikar Dronamraju