From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH] net: Statically initialize init_net.dev_base_head Date: Wed, 18 Jul 2012 16:21:59 -0400 Message-ID: <20120718202159.GA30706@hmsreliant.think-freely.org> References: <20120718190607.22923.77935.stgit@host1-mdrustad.localdomain> <20120718201149.GB22057@hmsreliant.think-freely.org> <20120718.132010.1765790775051953381.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mark.d.rustad@intel.com, netdev@vger.kernel.org, gaofeng@cn.fujitsu.com, eric.dumazet@gmail.com To: David Miller Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:56208 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755945Ab2GRUWF (ORCPT ); Wed, 18 Jul 2012 16:22:05 -0400 Content-Disposition: inline In-Reply-To: <20120718.132010.1765790775051953381.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jul 18, 2012 at 01:20:10PM -0700, David Miller wrote: > From: Neil Horman > Date: Wed, 18 Jul 2012 16:11:49 -0400 > > > On Wed, Jul 18, 2012 at 12:06:07PM -0700, Mark Rustad wrote: > >> This change eliminates an initialization-order hazard most > >> recently seen when netprio_cgroup is built into the kernel. > >> > >> With thanks to Eric Dumazet for catching a bug. > >> > >> Signed-off-by: Mark Rustad > ... > > I think dave was going to take John Fastabends patch from earlier today, but > > this works just as well. Long term I'm going to look into delaying > > initzlization for cgroups, as it creates a strange initialization state when you > > have a module_init routine registered. > > Neil, any particular preference between John's and Mark's version > of the fix? > I think they're both perfectly good. If I had to choose I'd say Marks, just because its done by initializing data, rather than adding more code to run every time we create a cgroup. Neil