From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
gleb@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: fix race with level interrupts
Date: Thu, 19 Jul 2012 12:15:11 +0300 [thread overview]
Message-ID: <20120719091510.GC20120@redhat.com> (raw)
In-Reply-To: <1342653762.2229.236.camel@bling.home>
On Wed, Jul 18, 2012 at 05:22:42PM -0600, Alex Williamson wrote:
> I hate reviewing code
> > > where I have to differentiate 'l' vs '1'.
> >
> > l is an illegal variable name? Switch to a different font.
>
> WTF
Really, you should use a font where these differ. I currently use
Monospace but there are many other good fonts. If you don't bugs sneak
in.
int x = 11;
and
int x = 1l;
Should look very different.
--
MST
next prev parent reply other threads:[~2012-07-19 9:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 21:52 [PATCH] kvm: fix race with level interrupts Michael S. Tsirkin
2012-07-18 22:16 ` Alex Williamson
2012-07-18 22:44 ` Michael S. Tsirkin
2012-07-18 23:22 ` Alex Williamson
2012-07-19 9:15 ` Michael S. Tsirkin [this message]
2012-07-19 12:06 ` Alex Williamson
2012-07-19 12:10 ` Michael S. Tsirkin
2012-07-19 7:51 ` Gleb Natapov
2012-07-18 22:26 ` Alex Williamson
2012-07-18 22:49 ` Michael S. Tsirkin
2012-07-18 23:20 ` Alex Williamson
2012-07-19 7:47 ` Gleb Natapov
2012-07-19 9:07 ` Michael S. Tsirkin
2012-07-19 12:11 ` Alex Williamson
2012-07-19 12:24 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719091510.GC20120@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.