From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 19 Jul 2012 09:48:51 -0400 Subject: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib In-Reply-To: <201207191102.21389.marex@denx.de> References: <1342324924-3282-1-git-send-email-macpaul@gmail.com> <201207190037.59281.vapier@gentoo.org> <201207191102.21389.marex@denx.de> Message-ID: <201207190948.53316.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 19 July 2012 05:02:21 Marek Vasut wrote: > Dear Mike Frysinger, > > On Sunday 15 July 2012 04:12:45 Marek Vasut wrote: > > > Dear Macpaul Lin, > > > > +void flush_cache(unsigned long addr, unsigned long size) > > > > +{ > > > > + flush_dcache_range(addr, addr + size); > > > > + invalidate_icache_range(addr, addr + size); > > > > > > You probably want to flush dcache in here and that's it. > > > > i don't think so ... i think that's what flush_dcache_range() is for. > > and our common/cmd_*.c files assume that flush_cache() will invalidate > > icache (see the bootm/load funcs that write executable content into > > memory and then flush the regions). > > Than it's borked on arm926ejs too ... ? if it doesn't flush icache in the flush_cache() function, then i would say so sounds like we should rip all this cache stuff out of common.h and into like cache.h so we can document the API expectations. i think Wolfgang was against this before, but maybe that was just creating a header for one specific cache macro and not all cache stuff ? -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: