From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Segregate memory domains in the GTT using coloring Date: Thu, 26 Jul 2012 13:00:45 +0200 Message-ID: <20120726110045.GC5326@phenom.ffwll.local> References: <20120726103419.GB5326@phenom.ffwll.local> <1343299772-26138-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 444D99EB26 for ; Thu, 26 Jul 2012 04:00:38 -0700 (PDT) Received: by bkcji2 with SMTP id ji2so1194347bkc.36 for ; Thu, 26 Jul 2012 04:00:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1343299772-26138-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jul 26, 2012 at 11:49:32AM +0100, Chris Wilson wrote: > Several functions of the GPU have the restriction that differing memory > domains cannot be placed next to each other (as the GPU may prefetch > beyond the end of one domain and hang as it crosses into the other > domain). We use the facility of the drm_mm to mark ranges with a > particular color that corresponds to the cache attributes of those pages > in order to prevent allocating adjacent blocks of differing memory > types. > > v2: Rebase ontop of drm_mm coloring v2. > v3: Fix rebinding existing gtt_space and add a verification routine. > > Signed-off-by: Chris Wilson Ok, history fixed. Can you please double-check that I haven't botched it? /me hangs head in shame over not noticing that nothing assings anything to obj->color ... -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48