From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mark A. Greer" Subject: Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC? Date: Thu, 26 Jul 2012 16:08:24 -0700 Message-ID: <20120726230824.GB20413@animalcreek.com> References: <20120717004010.GA6612@animalcreek.com> <20120718022035.GC18663@animalcreek.com> <20120718172654.GA27904@animalcreek.com> <20120726230630.GA21004@animalcreek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail20.dotsterhost.com ([66.11.232.73]:56912 "EHLO mail20.dotsterhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753009Ab2GZXIo (ORCPT ); Thu, 26 Jul 2012 19:08:44 -0400 Content-Disposition: inline In-Reply-To: <20120726230630.GA21004@animalcreek.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Juha Kuikka Cc: Joe Woodward , Paul Walmsley , Kevin Hilman , linux-omap@vger.kernel.org On Thu, Jul 26, 2012 at 04:06:30PM -0700, Mark A. Greer wrote: > On Thu, Jul 26, 2012 at 02:09:33PM -0700, Juha Kuikka wrote: > > Just applying Mark's patch on top of > > 55936cdfaaf11ac352b56bc58e42d6661e65ee13 (linux-omap) is not enough, I > > also need to set the OMAP3_HAS_IVA_REGS for the 3430 as well. > > > > Inlined patch: > > > > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c > > index 4072fbd..45d3eb4 100644 > > --- a/arch/arm/mach-omap2/id.c > > +++ b/arch/arm/mach-omap2/id.c > > @@ -244,7 +244,7 @@ void __init omap3xxx_check_features(void) > > if (cpu_is_omap3630()) > > omap_features |= OMAP3_HAS_192MHZ_CLK | OMAP3_HAS_IVA_REGS; > > if (cpu_is_omap3430() || cpu_is_omap3630()) > > - omap_features |= OMAP3_HAS_IO_WAKEUP; > > + omap_features |= OMAP3_HAS_IO_WAKEUP | OMAP3_HAS_IVA_REGS; > > if (cpu_is_omap3630() || omap_rev() == OMAP3430_REV_ES3_1 || > > omap_rev() == OMAP3430_REV_ES3_1_2) > > omap_features |= OMAP3_HAS_IO_CHAIN_CTRL; > > Thank you. I meant to add, "Please make a formal patch for review so you can get credit for your work." Mark