All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix
Date: Sun, 29 Jul 2012 09:06:41 +0200	[thread overview]
Message-ID: <201207290906.41794.marex@denx.de> (raw)
In-Reply-To: <5014DF95.7070803@denx.de>

Dear Stefano Babic,

[...]
> > 
> > Given that the PSU regs for example have completely different register
> > map and bit maps in the registers itself, I'd be careful with the
> > renaming.
> 
> Personally I prefer that the function names are the same and the
> implementation itself of the function hides the SOC details.

Sure, I was just pointing out the PSU regs differ on MX23 and MX28 ... so maybe 
we should have separate regs-mx28-power.h and regs-mx23-power.h. But then it'd 
be troublesome to make the code generic enough (not full of ifdefs). On the 
other hand, if both those header files contained reg. structures named the same 
and were included based on the CPU type, that might just work.

> In this
> way, we provide the same interface API to the user (=the board
> maintainer) and to the drivers that are surely shared between the MX28
> and MX23.

Of course.

> Best regards,
> Stefano Babic

Best regards,
Marek Vasut

  reply	other threads:[~2012-07-29  7:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-28 22:50 [U-Boot] [RFC PATCH 0/5] Rework for mxs SoC family support Otavio Salvador
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 1/5] mxs: reorganize source directory for easy sharing of code in i.MXS SoCs Otavio Salvador
2012-08-04 22:33   ` Otavio Salvador
2012-08-04 22:40   ` Marek Vasut
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix Otavio Salvador
2012-07-29  1:33   ` Marek Vasut
2012-07-29  7:00     ` Stefano Babic
2012-07-29  7:06       ` Marek Vasut [this message]
2012-07-29 12:43       ` Otavio Salvador
2012-07-29 12:55         ` Marek Vasut
2012-07-29 13:01           ` Otavio Salvador
2012-07-29 13:10             ` Marek Vasut
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 3/5] mxs: prefix register structs " Otavio Salvador
2012-08-04 22:34   ` Otavio Salvador
2012-08-04 22:40   ` Marek Vasut
2012-08-04 22:44     ` Otavio Salvador
2012-08-04 22:46       ` Marek Vasut
2012-08-05  6:46         ` Stefano Babic
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 4/5] mxs: Reowork SPL to use 'mxs' prefix for methods Otavio Salvador
2012-08-04 22:35   ` Otavio Salvador
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 5/5] mxs: rename mx28.c to mxs.c as it is common to i.MX233 and i.MX28 SoCs Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207290906.41794.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.