From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION Date: Sun, 29 Jul 2012 15:27:58 +0300 Message-ID: <20120729122758.GE15558@redhat.com> References: <1343093180-5598-1-git-send-email-nab@linux-iscsi.org> <20120724015634.GD4093@kroah.com> <1343162724.1813.111.camel@haakon2.linux-iscsi.org> <500FF05B.8060602@redhat.com> <1343250648.1813.169.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1343250648.1813.169.camel@haakon2.linux-iscsi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Nicholas A. Bellinger" Cc: Jens Axboe , linux-scsi , kvm-devel , Greg Kroah-Hartman , qemu-devel , lf-virt , Anthony Liguori , target-devel , Avi Kivity , Paolo Bonzini , Zhi Yong Wu , Christoph Hellwig , Stefan Hajnoczi List-Id: linux-scsi@vger.kernel.org On Wed, Jul 25, 2012 at 02:10:48PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2012-07-25 at 16:10 +0300, Avi Kivity wrote: > > On 07/24/2012 11:45 PM, Nicholas A. Bellinger wrote: > > > > >> > diff --git a/drivers/vhost/tcm_vhost.h b/drivers/vhost/tcm_vhost.h > > >> > index e942df9..3d5378f 100644 > > >> > --- a/drivers/vhost/tcm_vhost.h > > >> > +++ b/drivers/vhost/tcm_vhost.h > > >> > @@ -80,7 +80,17 @@ struct tcm_vhost_tport { > > >> > > > >> > #include > > >> > > > >> > +/* > > >> > + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. > > >> > + * > > >> > + * ABI Rev 0: All pre 2012 revisions used by prototype out-of-tree code > > >> > + * ABI Rev 1: 2012 version for v3.6 kernel merge candiate > > >> > + */ > > > > > > If it's out of tree, why consider it at all? Put a stable ABI in tree > > and extend it in compatible ways. > > > > > > This comment was supposed to convey that ABI=0 vhost-scsi userspace code > is not supported with tcm_vhost mainline code. > > But obviously that was not clear enough here. Updating the comment to > reflect to make this clear. > > So the main question here was if it's fine to start with ABI=1, and > require >= ABI=1 for all vhost-scsi userspace code to function with > tcm_vhost. > > The idea was to avoid confusion for the ABI=0 vhost-scsi code that's > been floating around for the last 2 years. > > --nab > > > > > > Yes but I am guessing that code does not invoke the ABI ioctl? -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvSar-0003NM-UU for qemu-devel@nongnu.org; Sun, 29 Jul 2012 08:27:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvSaq-0008NA-SM for qemu-devel@nongnu.org; Sun, 29 Jul 2012 08:27:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvSaq-0008N6-KZ for qemu-devel@nongnu.org; Sun, 29 Jul 2012 08:27:32 -0400 Date: Sun, 29 Jul 2012 15:27:58 +0300 From: "Michael S. Tsirkin" Message-ID: <20120729122758.GE15558@redhat.com> References: <1343093180-5598-1-git-send-email-nab@linux-iscsi.org> <20120724015634.GD4093@kroah.com> <1343162724.1813.111.camel@haakon2.linux-iscsi.org> <500FF05B.8060602@redhat.com> <1343250648.1813.169.camel@haakon2.linux-iscsi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1343250648.1813.169.camel@haakon2.linux-iscsi.org> Subject: Re: [Qemu-devel] [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Nicholas A. Bellinger" Cc: Jens Axboe , linux-scsi , kvm-devel , Greg Kroah-Hartman , Hannes Reinecke , Zhi Yong Wu , qemu-devel , lf-virt , Anthony Liguori , target-devel , Avi Kivity , Paolo Bonzini , Zhi Yong Wu , Christoph Hellwig , Stefan Hajnoczi On Wed, Jul 25, 2012 at 02:10:48PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2012-07-25 at 16:10 +0300, Avi Kivity wrote: > > On 07/24/2012 11:45 PM, Nicholas A. Bellinger wrote: > > > > >> > diff --git a/drivers/vhost/tcm_vhost.h b/drivers/vhost/tcm_vhost.h > > >> > index e942df9..3d5378f 100644 > > >> > --- a/drivers/vhost/tcm_vhost.h > > >> > +++ b/drivers/vhost/tcm_vhost.h > > >> > @@ -80,7 +80,17 @@ struct tcm_vhost_tport { > > >> > > > >> > #include > > >> > > > >> > +/* > > >> > + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. > > >> > + * > > >> > + * ABI Rev 0: All pre 2012 revisions used by prototype out-of-tree code > > >> > + * ABI Rev 1: 2012 version for v3.6 kernel merge candiate > > >> > + */ > > > > > > If it's out of tree, why consider it at all? Put a stable ABI in tree > > and extend it in compatible ways. > > > > > > This comment was supposed to convey that ABI=0 vhost-scsi userspace code > is not supported with tcm_vhost mainline code. > > But obviously that was not clear enough here. Updating the comment to > reflect to make this clear. > > So the main question here was if it's fine to start with ABI=1, and > require >= ABI=1 for all vhost-scsi userspace code to function with > tcm_vhost. > > The idea was to avoid confusion for the ABI=0 vhost-scsi code that's > been floating around for the last 2 years. > > --nab > > > > > > Yes but I am guessing that code does not invoke the ABI ioctl? -- MST