From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502Ab2HCLN7 (ORCPT ); Fri, 3 Aug 2012 07:13:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11690 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753418Ab2HCLN6 (ORCPT ); Fri, 3 Aug 2012 07:13:58 -0400 Date: Fri, 3 Aug 2012 08:13:09 -0300 From: Rafael Aquini To: Rik van Riel Cc: Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , "Michael S. Tsirkin" , Mel Gorman , Andi Kleen , Andrew Morton , Konrad Rzeszutek Wilk , Rafael Aquini Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Message-ID: <20120803111309.GA1848@t510.redhat.com> References: <49f828a9331c9b729fcf77226006921ec5bc52fa.1342485774.git.aquini@redhat.com> <20120718054824.GA32341@bbox> <20120720194858.GA16249@t510.redhat.com> <20120723023332.GA6832@bbox> <20120723181952.GA27373@t510.redhat.com> <5019975B.6010708@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5019975B.6010708@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 01, 2012 at 04:53:47PM -0400, Rik van Riel wrote: > On 07/23/2012 02:19 PM, Rafael Aquini wrote: > > >In a glance, I believe this whole dance you're suggesting might just be too much > >of an overcomplication, and the best approach would be simply teaching the > >hotplug bits about the ballooned corner case just like it's being done to > >compaction/migration. However, I'll look at it carefully before making any other > >adjustments/propositions over here. > > Compaction and hotplug do essentially the same thing > here: "collect all the movable pages from a page block, > and move them elsewhere". > > Whether or not it is easier for them to share code, or > to duplicate a few lines of code, is something that can > be looked into later. I'm 100% in agreement with your thoughts here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx160.postini.com [74.125.245.160]) by kanga.kvack.org (Postfix) with SMTP id 8E8816B0044 for ; Fri, 3 Aug 2012 07:13:52 -0400 (EDT) Date: Fri, 3 Aug 2012 08:13:09 -0300 From: Rafael Aquini Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Message-ID: <20120803111309.GA1848@t510.redhat.com> References: <49f828a9331c9b729fcf77226006921ec5bc52fa.1342485774.git.aquini@redhat.com> <20120718054824.GA32341@bbox> <20120720194858.GA16249@t510.redhat.com> <20120723023332.GA6832@bbox> <20120723181952.GA27373@t510.redhat.com> <5019975B.6010708@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5019975B.6010708@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , "Michael S. Tsirkin" , Mel Gorman , Andi Kleen , Andrew Morton , Konrad Rzeszutek Wilk , Rafael Aquini On Wed, Aug 01, 2012 at 04:53:47PM -0400, Rik van Riel wrote: > On 07/23/2012 02:19 PM, Rafael Aquini wrote: > > >In a glance, I believe this whole dance you're suggesting might just be too much > >of an overcomplication, and the best approach would be simply teaching the > >hotplug bits about the ballooned corner case just like it's being done to > >compaction/migration. However, I'll look at it carefully before making any other > >adjustments/propositions over here. > > Compaction and hotplug do essentially the same thing > here: "collect all the movable pages from a page block, > and move them elsewhere". > > Whether or not it is easier for them to share code, or > to duplicate a few lines of code, is something that can > be looked into later. I'm 100% in agreement with your thoughts here. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rafael Aquini Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Date: Fri, 3 Aug 2012 08:13:09 -0300 Message-ID: <20120803111309.GA1848@t510.redhat.com> References: <49f828a9331c9b729fcf77226006921ec5bc52fa.1342485774.git.aquini@redhat.com> <20120718054824.GA32341@bbox> <20120720194858.GA16249@t510.redhat.com> <20120723023332.GA6832@bbox> <20120723181952.GA27373@t510.redhat.com> <5019975B.6010708@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5019975B.6010708@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rik van Riel Cc: Konrad Rzeszutek Wilk , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Minchan Kim , Andi Kleen , Andrew Morton , Rafael Aquini List-Id: virtualization@lists.linuxfoundation.org On Wed, Aug 01, 2012 at 04:53:47PM -0400, Rik van Riel wrote: > On 07/23/2012 02:19 PM, Rafael Aquini wrote: > > >In a glance, I believe this whole dance you're suggesting might just be too much > >of an overcomplication, and the best approach would be simply teaching the > >hotplug bits about the ballooned corner case just like it's being done to > >compaction/migration. However, I'll look at it carefully before making any other > >adjustments/propositions over here. > > Compaction and hotplug do essentially the same thing > here: "collect all the movable pages from a page block, > and move them elsewhere". > > Whether or not it is easier for them to share code, or > to duplicate a few lines of code, is something that can > be looked into later. I'm 100% in agreement with your thoughts here.