Hi Andrew, After merging the akpm tree, today's linux-next build (x86_64 allmodconfig) failed like this: fs/gfs2/rgrp.c: In function 'gfs2_rs_alloc': fs/gfs2/rgrp.c:456:2: error: implicit declaration of function 'rb_init_node' [-Werror=implicit-function-declaration] Caused by commit 5599fe1ab023 ("rbtree: empty nodes have no color") from the akpm tree interacting with commit cde7c325077b ("GFS2: Add structure to contain rgrp, bitmap, offset tuple") from the gfs2 tree. I have applied the following merge fix patch (which is probably not sufficient). From: Stephen Rothwell Date: Mon, 6 Aug 2012 13:35:11 +1000 Subject: [PATCH] rbtree/gfs2: remove call to rb_init_node Signed-off-by: Stephen Rothwell --- fs/gfs2/rgrp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 06476b3..6fb3a57 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -453,8 +453,6 @@ int gfs2_rs_alloc(struct gfs2_inode *ip) if (!res) error = -ENOMEM; - rb_init_node(&res->rs_node); - down_write(&ip->i_rw_mutex); if (ip->i_res) kmem_cache_free(gfs2_rsrv_cachep, res); @@ -486,7 +484,6 @@ static void __rs_deltree(struct gfs2_inode *ip, struct gfs2_blkreserv *rs) rgd = rs->rs_rbm.rgd; trace_gfs2_rs(ip, rs, TRACE_RS_TREEDEL); rb_erase(&rs->rs_node, &rgd->rd_rstree); - rb_init_node(&rs->rs_node); BUG_ON(!rgd->rd_rs_cnt); rgd->rd_rs_cnt--; -- Cheers, Stephen Rothwell sfr@canb.auug.org.au