Re: [PATCH v8] media: Add stk1160 new driver

Re: [PATCH v8] media: Add stk1160 new driver

[Ezequiel Garcia]

Hi Mauro,

On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> This driver adds support for stk1160 usb bridge as used in some
> video/audio usb capture devices.
> It is a complete rewrite of staging/media/easycap driver and
> it's expected as a replacement.
> ---
>

I just sent v8, but it looks it wasn't received by patchwork either.

What's going on?

Regards,
Ezequiel.

Re: [PATCH v8] media: Add stk1160 new driver

[Ezequiel Garcia]

Hi Mauro,

On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> This driver adds support for stk1160 usb bridge as used in some
> video/audio usb capture devices.
> It is a complete rewrite of staging/media/easycap driver and
> it's expected as a replacement.
> ---
>

I just sent v8, but it looks it wasn't received by patchwork either.

What's going on?

Regards,
Ezequiel.

Re: [PATCH v8] media: Add stk1160 new driver

[Mauro Carvalho Chehab]

Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
> Hi Mauro,
> 
> On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>> This driver adds support for stk1160 usb bridge as used in some
>> video/audio usb capture devices.
>> It is a complete rewrite of staging/media/easycap driver and
>> it's expected as a replacement.
>> ---
>>
> 
> I just sent v8, but it looks it wasn't received by patchwork either.
> 
> What's going on?

The patch didn't arrive at linux-media ML.

Not sure why it got rejected at vger. I suggest you to ping vger admin
to see why your patches are being rejected there.

I tested parsing this patch manually and patchwork accepted. So, once
the issue with vger is solved, other patches should be properly
handled there.

Regards,
Mauro

Re: [PATCH v8] media: Add stk1160 new driver

[Mauro Carvalho Chehab]

Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
> Hi Mauro,
> 
> On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>> This driver adds support for stk1160 usb bridge as used in some
>> video/audio usb capture devices.
>> It is a complete rewrite of staging/media/easycap driver and
>> it's expected as a replacement.
>> ---
>>
> 
> I just sent v8, but it looks it wasn't received by patchwork either.
> 
> What's going on?

The patch didn't arrive at linux-media ML.

Not sure why it got rejected at vger. I suggest you to ping vger admin
to see why your patches are being rejected there.

I tested parsing this patch manually and patchwork accepted. So, once
the issue with vger is solved, other patches should be properly
handled there.

Regards,
Mauro

Re: [PATCH v8] media: Add stk1160 new driver

[Hans Verkuil]

On Mon August 6 2012 16:08:33 Mauro Carvalho Chehab wrote:
> Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
> > Hi Mauro,
> > 
> > On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> >> This driver adds support for stk1160 usb bridge as used in some
> >> video/audio usb capture devices.
> >> It is a complete rewrite of staging/media/easycap driver and
> >> it's expected as a replacement.
> >> ---
> >>
> > 
> > I just sent v8, but it looks it wasn't received by patchwork either.
> > 
> > What's going on?
> 
> The patch didn't arrive at linux-media ML.
> 
> Not sure why it got rejected at vger. I suggest you to ping vger admin
> to see why your patches are being rejected there.
> 
> I tested parsing this patch manually and patchwork accepted. So, once
> the issue with vger is solved, other patches should be properly
> handled there.

Could it be related to the fact that a gmail account is used? Konke Radlow
had a similar issue recently when he posted a patch from a gmail account. It
worked fine when posted from a company account.

Regards,

	Hans

Re: [PATCH v8] media: Add stk1160 new driver

[Hans Verkuil]

On Mon August 6 2012 16:08:33 Mauro Carvalho Chehab wrote:
> Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
> > Hi Mauro,
> > 
> > On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> >> This driver adds support for stk1160 usb bridge as used in some
> >> video/audio usb capture devices.
> >> It is a complete rewrite of staging/media/easycap driver and
> >> it's expected as a replacement.
> >> ---
> >>
> > 
> > I just sent v8, but it looks it wasn't received by patchwork either.
> > 
> > What's going on?
> 
> The patch didn't arrive at linux-media ML.
> 
> Not sure why it got rejected at vger. I suggest you to ping vger admin
> to see why your patches are being rejected there.
> 
> I tested parsing this patch manually and patchwork accepted. So, once
> the issue with vger is solved, other patches should be properly
> handled there.

Could it be related to the fact that a gmail account is used? Konke Radlow
had a similar issue recently when he posted a patch from a gmail account. It
worked fine when posted from a company account.

Regards,

	Hans

Re: [alsa-devel] [PATCH v8] media: Add stk1160 new driver

[Ezequiel Garcia]

On Mon, Aug 6, 2012 at 11:18 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On Mon August 6 2012 16:08:33 Mauro Carvalho Chehab wrote:
>> Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
>> > Hi Mauro,
>> >
>> > On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>> >> This driver adds support for stk1160 usb bridge as used in some
>> >> video/audio usb capture devices.
>> >> It is a complete rewrite of staging/media/easycap driver and
>> >> it's expected as a replacement.
>> >> ---
>> >>
>> >
>> > I just sent v8, but it looks it wasn't received by patchwork either.
>> >
>> > What's going on?
>>
>> The patch didn't arrive at linux-media ML.
>>
>> Not sure why it got rejected at vger. I suggest you to ping vger admin
>> to see why your patches are being rejected there.
>>
>> I tested parsing this patch manually and patchwork accepted. So, once
>> the issue with vger is solved, other patches should be properly
>> handled there.
>
> Could it be related to the fact that a gmail account is used? Konke Radlow
> had a similar issue recently when he posted a patch from a gmail account. It
> worked fine when posted from a company account.
>

FWIW, I've always sent my patches from git-send-email through my gmail account.
Don't know if this is an issue, but it never seemed to.

Regards,
Ezequiel.

Re: [alsa-devel] [PATCH v8] media: Add stk1160 new driver

[Ezequiel Garcia]

Hi Mauro,

On Mon, Aug 6, 2012 at 12:21 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> On Mon, Aug 6, 2012 at 11:18 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> On Mon August 6 2012 16:08:33 Mauro Carvalho Chehab wrote:
>>> Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
>>> > Hi Mauro,
>>> >
>>> > On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>>> >> This driver adds support for stk1160 usb bridge as used in some
>>> >> video/audio usb capture devices.
>>> >> It is a complete rewrite of staging/media/easycap driver and
>>> >> it's expected as a replacement.
>>> >> ---
>>> >>
>>> >
>>> > I just sent v8, but it looks it wasn't received by patchwork either.
>>> >
>>> > What's going on?
>>>
>>> The patch didn't arrive at linux-media ML.
>>>
>>> Not sure why it got rejected at vger. I suggest you to ping vger admin
>>> to see why your patches are being rejected there.
>>>
>>> I tested parsing this patch manually and patchwork accepted. So, once
>>> the issue with vger is solved, other patches should be properly
>>> handled there.
>>
>> Could it be related to the fact that a gmail account is used? Konke Radlow
>> had a similar issue recently when he posted a patch from a gmail account. It
>> worked fine when posted from a company account.
>>
>
> FWIW, I've always sent my patches from git-send-email through my gmail account.
> Don't know if this is an issue, but it never seemed to.
>

On a second thought, perhaps it makes sense to have a git repo (on linuxtv.org)
for me to work on stk1160.
That way I could simply send "git pull" requests instead of patches.

I'm not sure if this is a better workflow and/or would allow for
easier reviewing.

Thanks,
Ezequiel.

Re: [alsa-devel] [PATCH v8] media: Add stk1160 new driver

[Ezequiel Garcia]

Hello,

On Mon, Aug 6, 2012 at 12:42 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> Hi Mauro,
>
> On Mon, Aug 6, 2012 at 12:21 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>> On Mon, Aug 6, 2012 at 11:18 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>> On Mon August 6 2012 16:08:33 Mauro Carvalho Chehab wrote:
>>>> Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
>>>> > Hi Mauro,
>>>> >
>>>> > On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>>>> >> This driver adds support for stk1160 usb bridge as used in some
>>>> >> video/audio usb capture devices.
>>>> >> It is a complete rewrite of staging/media/easycap driver and
>>>> >> it's expected as a replacement.
>>>> >> ---
>>>> >>
>>>> >
>>>> > I just sent v8, but it looks it wasn't received by patchwork either.
>>>> >
>>>> > What's going on?
>>>>
>>>> The patch didn't arrive at linux-media ML.
>>>>
>>>> Not sure why it got rejected at vger. I suggest you to ping vger admin
>>>> to see why your patches are being rejected there.
>>>>
>>>> I tested parsing this patch manually and patchwork accepted. So, once
>>>> the issue with vger is solved, other patches should be properly
>>>> handled there.
>>>
>>> Could it be related to the fact that a gmail account is used? Konke Radlow
>>> had a similar issue recently when he posted a patch from a gmail account. It
>>> worked fine when posted from a company account.
>>>
>>
>> FWIW, I've always sent my patches from git-send-email through my gmail account.
>> Don't know if this is an issue, but it never seemed to.
>>
>
> On a second thought, perhaps it makes sense to have a git repo (on linuxtv.org)
> for me to work on stk1160.
> That way I could simply send "git pull" requests instead of patches.
>
> I'm not sure if this is a better workflow and/or would allow for
> easier reviewing.
>

Well, I just got an answer from vger administrator. He told me the
patch was exceeding
the allowed limit. Which I later discovered it was documented here:

http://vger.kernel.org/majordomo-info.html

Apparently, there is a 100, 000 characters limit.

So, how do we proceed?

Regards,
Ezequiel.

Re: [PATCH v8] media: Add stk1160 new driver

[Ezequiel Garcia]

Hello,

On Mon, Aug 6, 2012 at 12:42 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> Hi Mauro,
>
> On Mon, Aug 6, 2012 at 12:21 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>> On Mon, Aug 6, 2012 at 11:18 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>> On Mon August 6 2012 16:08:33 Mauro Carvalho Chehab wrote:
>>>> Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
>>>> > Hi Mauro,
>>>> >
>>>> > On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>>>> >> This driver adds support for stk1160 usb bridge as used in some
>>>> >> video/audio usb capture devices.
>>>> >> It is a complete rewrite of staging/media/easycap driver and
>>>> >> it's expected as a replacement.
>>>> >> ---
>>>> >>
>>>> >
>>>> > I just sent v8, but it looks it wasn't received by patchwork either.
>>>> >
>>>> > What's going on?
>>>>
>>>> The patch didn't arrive at linux-media ML.
>>>>
>>>> Not sure why it got rejected at vger. I suggest you to ping vger admin
>>>> to see why your patches are being rejected there.
>>>>
>>>> I tested parsing this patch manually and patchwork accepted. So, once
>>>> the issue with vger is solved, other patches should be properly
>>>> handled there.
>>>
>>> Could it be related to the fact that a gmail account is used? Konke Radlow
>>> had a similar issue recently when he posted a patch from a gmail account. It
>>> worked fine when posted from a company account.
>>>
>>
>> FWIW, I've always sent my patches from git-send-email through my gmail account.
>> Don't know if this is an issue, but it never seemed to.
>>
>
> On a second thought, perhaps it makes sense to have a git repo (on linuxtv.org)
> for me to work on stk1160.
> That way I could simply send "git pull" requests instead of patches.
>
> I'm not sure if this is a better workflow and/or would allow for
> easier reviewing.
>

Well, I just got an answer from vger administrator. He told me the
patch was exceeding
the allowed limit. Which I later discovered it was documented here:

http://vger.kernel.org/majordomo-info.html

Apparently, there is a 100, 000 characters limit.

So, how do we proceed?

Regards,
Ezequiel.

Re: [alsa-devel] [PATCH v8] media: Add stk1160 new driver

[Ezequiel Garcia]

Hi Mauro,

On Mon, Aug 6, 2012 at 4:13 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>>
>> On a second thought, perhaps it makes sense to have a git repo (on linuxtv.org)
>> for me to work on stk1160.
>> That way I could simply send "git pull" requests instead of patches.
>>
>> I'm not sure if this is a better workflow and/or would allow for
>> easier reviewing.
>>
>
> Well, I just got an answer from vger administrator. He told me the
> patch was exceeding
> the allowed limit. Which I later discovered it was documented here:
>
> http://vger.kernel.org/majordomo-info.html
>
> Apparently, there is a 100, 000 characters limit.
>
> So, how do we proceed?
>

Ping! Could you take a look at this?
I'd like to solve the pending issues (see previous mails),
in order to know if the driver will need further work.

... or perhaps we can leave this for after the merge window, when
you (and everyone) are be less busy.

I *really* hope I'm not spamming. In that case, feel free to say so.
Thanks,
Ezequiel.

Re: [alsa-devel] [PATCH v8] media: Add stk1160 new driver

[Mauro Carvalho Chehab]

Em 09-08-2012 09:24, Ezequiel Garcia escreveu:
> Hi Mauro,
> 
> On Mon, Aug 6, 2012 at 4:13 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>>>
>>> On a second thought, perhaps it makes sense to have a git repo (on linuxtv.org)
>>> for me to work on stk1160.
>>> That way I could simply send "git pull" requests instead of patches.
>>>
>>> I'm not sure if this is a better workflow and/or would allow for
>>> easier reviewing.
>>>
>>
>> Well, I just got an answer from vger administrator. He told me the
>> patch was exceeding
>> the allowed limit. Which I later discovered it was documented here:
>>
>> http://vger.kernel.org/majordomo-info.html
>>
>> Apparently, there is a 100, 000 characters limit.
>>
>> So, how do we proceed?
>>
> 
> Ping! Could you take a look at this?
> I'd like to solve the pending issues (see previous mails),
> in order to know if the driver will need further work.
> 
> ... or perhaps we can leave this for after the merge window, when
> you (and everyone) are be less busy.
> 
> I *really* hope I'm not spamming. In that case, feel free to say so.

The merge window was closed already. I pushed this patch directly into patchwork,
so I should be handling it sooner or later.

Unfortunately, I had a crash on my home volume group, and I'm busy those
days recovering data from it. It seems I'll be able to recover everything,
but I'll need to move about 800GB of data between two disks (one of them is
a slow one), plus my backup machine. I'll likely break it into several smaller 
logical volumes, in order to help me to keep the backup updated. So, 
that'll keep me busy for a while. In the meantime, I'm working on a slow
notebook. So, I might still be able to review and add some patches upstream,
especially the more trivial ones.

Regards,
Mauro

Re: [PATCH v8] media: Add stk1160 new driver

[Mauro Carvalho Chehab]

Em 09-08-2012 09:24, Ezequiel Garcia escreveu:
> Hi Mauro,
> 
> On Mon, Aug 6, 2012 at 4:13 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>>>
>>> On a second thought, perhaps it makes sense to have a git repo (on linuxtv.org)
>>> for me to work on stk1160.
>>> That way I could simply send "git pull" requests instead of patches.
>>>
>>> I'm not sure if this is a better workflow and/or would allow for
>>> easier reviewing.
>>>
>>
>> Well, I just got an answer from vger administrator. He told me the
>> patch was exceeding
>> the allowed limit. Which I later discovered it was documented here:
>>
>> http://vger.kernel.org/majordomo-info.html
>>
>> Apparently, there is a 100, 000 characters limit.
>>
>> So, how do we proceed?
>>
> 
> Ping! Could you take a look at this?
> I'd like to solve the pending issues (see previous mails),
> in order to know if the driver will need further work.
> 
> ... or perhaps we can leave this for after the merge window, when
> you (and everyone) are be less busy.
> 
> I *really* hope I'm not spamming. In that case, feel free to say so.

The merge window was closed already. I pushed this patch directly into patchwork,
so I should be handling it sooner or later.

Unfortunately, I had a crash on my home volume group, and I'm busy those
days recovering data from it. It seems I'll be able to recover everything,
but I'll need to move about 800GB of data between two disks (one of them is
a slow one), plus my backup machine. I'll likely break it into several smaller 
logical volumes, in order to help me to keep the backup updated. So, 
that'll keep me busy for a while. In the meantime, I'm working on a slow
notebook. So, I might still be able to review and add some patches upstream,
especially the more trivial ones.

Regards,
Mauro

Re: [alsa-devel] [PATCH v8] media: Add stk1160 new driver

[Ezequiel Garcia]

On Thu, Aug 9, 2012 at 9:33 AM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> Em 09-08-2012 09:24, Ezequiel Garcia escreveu:
>> Hi Mauro,
>>
>> On Mon, Aug 6, 2012 at 4:13 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>>>>
>>>> On a second thought, perhaps it makes sense to have a git repo (on linuxtv.org)
>>>> for me to work on stk1160.
>>>> That way I could simply send "git pull" requests instead of patches.
>>>>
>>>> I'm not sure if this is a better workflow and/or would allow for
>>>> easier reviewing.
>>>>
>>>
>>> Well, I just got an answer from vger administrator. He told me the
>>> patch was exceeding
>>> the allowed limit. Which I later discovered it was documented here:
>>>
>>> http://vger.kernel.org/majordomo-info.html
>>>
>>> Apparently, there is a 100, 000 characters limit.
>>>
>>> So, how do we proceed?
>>>
>>
>> Ping! Could you take a look at this?
>> I'd like to solve the pending issues (see previous mails),
>> in order to know if the driver will need further work.
>>
>> ... or perhaps we can leave this for after the merge window, when
>> you (and everyone) are be less busy.
>>
>> I *really* hope I'm not spamming. In that case, feel free to say so.
>
> The merge window was closed already.

Yes, you're right. I'm still unsure about the work flow.

> I pushed this patch directly into patchwork,
> so I should be handling it sooner or later.
>

Yes, I noticed it after sending the mail.

> Unfortunately, I had a crash on my home volume group, and I'm busy those
> days recovering data from it. It seems I'll be able to recover everything,
> but I'll need to move about 800GB of data between two disks (one of them is
> a slow one), plus my backup machine. I'll likely break it into several smaller
> logical volumes, in order to help me to keep the backup updated. So,
> that'll keep me busy for a while. In the meantime, I'm working on a slow
> notebook. So, I might still be able to review and add some patches upstream,
> especially the more trivial ones.
>

Ouch! I'm sorry to hear that. I hope you can recover soon.

I'll stay tuned for your comments (and I'll stop bothering).

Thanks for your reply!
Ezequiel.

Re: [PATCH v8] media: Add stk1160 new driver

[Mauro Carvalho Chehab]

Patch looks ok. Just a few comments:

Em 06-08-2012 10:38, Ezequiel Garcia escreveu:
> This driver adds support for stk1160 usb bridge as used in some
> video/audio usb capture devices.
> It is a complete rewrite of staging/media/easycap driver and
> it's expected as a replacement.
> ---

Please don't add a "---" here. Everything after a --- are discarded
by my scripts (and by most other kernel developer scripts).

> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>

Hmm... weren't it reviewed already be them?

> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
> diff --git a/drivers/media/video/stk1160/Makefile b/drivers/media/video/stk1160/Makefile
> new file mode 100644
> index 0000000..8f66a78
> --- /dev/null
> +++ b/drivers/media/video/stk1160/Makefile
> @@ -0,0 +1,12 @@
> +obj-stk1160-ac97-$(CONFIG_VIDEO_STK1160_AC97) := stk1160-ac97.o
> +
> +stk1160-y := 	stk1160-core.o \
> +		stk1160-v4l.o \
> +		stk1160-video.o \
> +		stk1160-i2c.o \
> +		$(obj-stk1160-ac97-y)
> +
> +obj-$(CONFIG_VIDEO_STK1160) += stk1160.o
> +
> +ccflags-y += -Wall

You shouldn't be adding the above here.

> +ccflags-y += -Idrivers/media/video

Ah, please split this patch into two patches: one with the new driver
addition, and another one with the removal of the driver at staging.

That will help to make the patch smaller, and avoids mixing two different
things at the same place.

Thanks,
Mauro

Re: [PATCH v8] media: Add stk1160 new driver

[Mauro Carvalho Chehab]

Patch looks ok. Just a few comments:

Em 06-08-2012 10:38, Ezequiel Garcia escreveu:
> This driver adds support for stk1160 usb bridge as used in some
> video/audio usb capture devices.
> It is a complete rewrite of staging/media/easycap driver and
> it's expected as a replacement.
> ---

Please don't add a "---" here. Everything after a --- are discarded
by my scripts (and by most other kernel developer scripts).

> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>

Hmm... weren't it reviewed already be them?

> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
> diff --git a/drivers/media/video/stk1160/Makefile b/drivers/media/video/stk1160/Makefile
> new file mode 100644
> index 0000000..8f66a78
> --- /dev/null
> +++ b/drivers/media/video/stk1160/Makefile
> @@ -0,0 +1,12 @@
> +obj-stk1160-ac97-$(CONFIG_VIDEO_STK1160_AC97) := stk1160-ac97.o
> +
> +stk1160-y := 	stk1160-core.o \
> +		stk1160-v4l.o \
> +		stk1160-video.o \
> +		stk1160-i2c.o \
> +		$(obj-stk1160-ac97-y)
> +
> +obj-$(CONFIG_VIDEO_STK1160) += stk1160.o
> +
> +ccflags-y += -Wall

You shouldn't be adding the above here.

> +ccflags-y += -Idrivers/media/video

Ah, please split this patch into two patches: one with the new driver
addition, and another one with the removal of the driver at staging.

That will help to make the patch smaller, and avoids mixing two different
things at the same place.

Thanks,
Mauro

Re: [PATCH v8] media: Add stk1160 new driver

[Ezequiel Garcia]

On Thu, Aug 9, 2012 at 5:25 PM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> Patch looks ok. Just a few comments:
>
> Em 06-08-2012 10:38, Ezequiel Garcia escreveu:
>> This driver adds support for stk1160 usb bridge as used in some
>> video/audio usb capture devices.
>> It is a complete rewrite of staging/media/easycap driver and
>> it's expected as a replacement.
>> ---
>
> Please don't add a "---" here. Everything after a --- are discarded
> by my scripts (and by most other kernel developer scripts).
>

Mmm, that line was meant to separate commit message from
message intended for developers/reviewers.
Do you feel all the text should be part of the commit message?

Anyway, I know currently it's wrong, since the SOB should be part of
commit message.

>> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
>> Cc: Takashi Iwai <tiwai@suse.de>
>> Cc: Hans Verkuil <hverkuil@xs4all.nl>
>> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
>
> Hmm... weren't it reviewed already be them?
>

Yes, Hans and Sylwester reviewed the various versions and Takashi
reviewed the alsa part.
I added a Cc, so they could review the changes made after their comments.
Do you think I should drop it in v9?

>> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
>> diff --git a/drivers/media/video/stk1160/Makefile b/drivers/media/video/stk1160/Makefile
>> new file mode 100644
>> index 0000000..8f66a78
>> --- /dev/null
>> +++ b/drivers/media/video/stk1160/Makefile
>> @@ -0,0 +1,12 @@
>> +obj-stk1160-ac97-$(CONFIG_VIDEO_STK1160_AC97) := stk1160-ac97.o
>> +
>> +stk1160-y :=         stk1160-core.o \
>> +             stk1160-v4l.o \
>> +             stk1160-video.o \
>> +             stk1160-i2c.o \
>> +             $(obj-stk1160-ac97-y)
>> +
>> +obj-$(CONFIG_VIDEO_STK1160) += stk1160.o
>> +
>> +ccflags-y += -Wall
>
> You shouldn't be adding the above here.
>

Okey.

>> +ccflags-y += -Idrivers/media/video
>
> Ah, please split this patch into two patches: one with the new driver
> addition, and another one with the removal of the driver at staging.
>
> That will help to make the patch smaller, and avoids mixing two different
> things at the same place.
>

No problem. I hope the easycap removal patch passes through vger!

> Thanks,

You are welcome :-)
Ezequiel.