All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: Horia Geanta <horia.geanta@freescale.com>
Cc: <linux-crypto@vger.kernel.org>,
	Herbert Xu <herbert@gondor.hengli.com.au>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 5/5] crypto: talitos - add IPsec ESN support
Date: Mon, 6 Aug 2012 20:47:51 -0500	[thread overview]
Message-ID: <20120806204751.1f6277ba8f7b1de92fd128ac@freescale.com> (raw)
In-Reply-To: <1343917001-20001-5-git-send-email-horia.geanta@freescale.com>

On Thu, 2 Aug 2012 17:16:41 +0300
Horia Geanta <horia.geanta@freescale.com> wrote:

> +			.cra_name = "authencesn(hmac(sha1),cbc(aes))",
> +			.cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos",

the driver name should be authencesn, too, no?

Also: if the algorithm name is really all that changes, can it be
done more space-efficiently with some string manipulation in the
algorithm registration loop?:  If registering an "authenc"
algorithm, also register an "authencesn" version.

The rest of the patchseries looks fine.

Thanks,

Kim

  reply	other threads:[~2012-08-07  1:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02 14:16 [PATCH 1/5] crypto: talitos - fix icv management on outbound direction Horia Geanta
2012-08-02 14:16 ` [PATCH 2/5] crypto: talitos - prune unneeded descriptor allocation param Horia Geanta
2012-08-02 14:16 ` [PATCH 3/5] crypto: talitos - change type and name for [src|dst]_is_chained Horia Geanta
2012-08-02 14:16 ` [PATCH 4/5] crypto: talitos - support for assoc data provided as scatterlist Horia Geanta
2012-08-02 14:16 ` [PATCH 5/5] crypto: talitos - add IPsec ESN support Horia Geanta
2012-08-07  1:47   ` Kim Phillips [this message]
2012-08-07  6:54     ` Geanta Neag Horia Ioan-B05471
2012-08-07 13:34       ` Geanta Neag Horia Ioan-B05471
2012-08-08  2:27         ` Kim Phillips
2012-08-09  1:32           ` [PATCH 1/2] crypto: talitos - consolidate cra_type assignments Kim Phillips
2012-08-20  8:33             ` Herbert Xu
2012-08-09  1:33           ` [PATCH 2/2] crypto: talitos - consolidate common cra_* assignments Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120806204751.1f6277ba8f7b1de92fd128ac@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=horia.geanta@freescale.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.