From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzZUG-0003q0-7e for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:37:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzZUF-00087G-01 for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:37:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzZUE-00087C-Mz for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:37:42 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79KbfOI004335 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Aug 2012 16:37:41 -0400 Date: Thu, 9 Aug 2012 17:38:17 -0300 From: Luiz Capitulino Message-ID: <20120809173817.7ea3c15e@doriath.home> In-Reply-To: <50240F9C.30202@redhat.com> References: <1344533300-6422-1-git-send-email-lcapitulino@redhat.com> <1344533300-6422-4-git-send-email-lcapitulino@redhat.com> <50240F9C.30202@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] qmp: qmp-events.txt: put events in alphabetical order List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, kraxel@redhat.com On Thu, 09 Aug 2012 13:29:32 -0600 Eric Blake wrote: > On 08/09/2012 11:28 AM, Luiz Capitulino wrote: > > Signed-off-by: Luiz Capitulino > > --- > > QMP/qmp-events.txt | 266 ++++++++++++++++++++++++++--------------------------- > > 1 file changed, 130 insertions(+), 136 deletions(-) > > Code motion that deletes 6 more lines than it adds? I'm assuming those > were blank lines, and that spacing is more consistent now, but it's > nicer to see a code motion patch with matching diffstat. Yes, blank lines. I'll avoid doing this in the future. > > Reviewed-by: Eric Blake > > > > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > > index b8afedb..e37a04e 100644 > > --- a/QMP/qmp-events.txt > > +++ b/QMP/qmp-events.txt > > Nits to possibly address in a followup patch (do NOT fix them at the > same time as code motion, though): > > > > > +SPICE_CONNECTED, SPICE_DISCONNECTED > > +----------------------------------- > > + > > +Emitted when a SPICE client connects or disconnects. > > Should this be broken into two listings? > > > +SPICE_INITIALIZED > > +----------------- > > + > > +Emitted after initial handshake and authentication takes place (if any) > > +and the SPICE channel is up'n'running > > Do we like this cutesy abbreviation, or should we spell out 'and'? > > > + > > +Data: > > + > > +- "server": Server information (json-object) > > + - "host": IP address (json-string) > > + - "port": port number (json-string) > > + - "family": address family (json-string, "ipv4" or "ipv6") > > + - "auth": authentication method (json-string, optional) > > +- "client": Client information (json-object) > > + - "host": IP address (json-string) > > + - "port": port number (json-string) > > + - "family": address family (json-string, "ipv4" or "ipv6") > > + - "connection-id": spice connection id. All channels with the same id > > + belong to the same spice session (json-int) > > + - "channel-type": channel type. "1" is the main control channel, filter for > > + this one if you want track spice sessions only (json-int) > > + - "channel-id": channel id. Usually "0", might be different needed when > > + multiple channels of the same type exist, such as multiple > > + display channels in a multihead setup (json-int) > > + - "tls": whevener the channel is encrypted (json-bool) > > s/whevener/whether/ >