From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzZWG-00055O-4P for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:39:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzZWE-0000ET-Qv for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:39:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzZWE-0000D9-IJ for qemu-devel@nongnu.org; Thu, 09 Aug 2012 16:39:46 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79KdjI4027099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Aug 2012 16:39:45 -0400 Date: Thu, 9 Aug 2012 17:40:21 -0300 From: Luiz Capitulino Message-ID: <20120809174021.608cf7d2@doriath.home> In-Reply-To: <5023FA12.2030005@redhat.com> References: <1344533300-6422-1-git-send-email-lcapitulino@redhat.com> <1344533300-6422-3-git-send-email-lcapitulino@redhat.com> <5023FA12.2030005@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] qmp: emit the WAKEUP event when the guest is put to run List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, kraxel@redhat.com On Thu, 09 Aug 2012 11:57:38 -0600 Eric Blake wrote: > On 08/09/2012 11:28 AM, Luiz Capitulino wrote: > > Today, the WAKEUP event is emitted when a wakeup _request_ is made. > > This could be the system_wakeup command, for example. > > > > A better semantic would be to emit the event when the guest is > > already running, as that's what matters in the end. This commit does > > that change. > > > > In theory, this could break compatibility. In practice, it shouldn't > > happen though, as clients shouldn't rely on timing characteristics of > > the events. That is, a client relying that the guest is not running > > when the event arrives may break if the event arrives after the guest > > is already running. > > Yeah, no problem with that semantic change from libvirt. > > > > +WAKEUP > > +------ > > + > > +Emitted when the guest has been waken up from S3 and is running. > > grammar: > > s/has been waken/has woken/ Fixed in v2. If I don't respin I'll merge the fixed version in the qmp branch (I won't respin just because of this). > > or maybe > > s/has been waken up/has been awakened/ >