From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v3 2/2] net: asix: add support for AX88772B
Date: Tue, 21 Aug 2012 14:19:23 -0400 [thread overview]
Message-ID: <201208211419.24812.vapier@gentoo.org> (raw)
In-Reply-To: <1345555393-11060-2-git-send-email-dev@lynxeye.de>
On Tuesday 21 August 2012 09:23:13 Lucas Stach wrote:
> + struct ueth_data *dev = (struct ueth_data *)eth->priv;
> + struct asix_private *priv = (struct asix_private *)dev->dev_priv;
not that it's harmful, but priv is void*, so the casts aren't needed
> + ALLOC_CACHE_ALIGN_BUFFER(unsigned char, ee_buf, 2);
> + ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buf, ETH_ALEN);
since you don't use both buffers at the same time, just declare one that is big
enough to work for either code path. so looks like you could throw away
ee_buf here.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120821/90f535e4/attachment.pgp>
next prev parent reply other threads:[~2012-08-21 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 13:23 [U-Boot] [Patch v3 1/2] net: introduce transparent driver private in ueth_data Lucas Stach
2012-08-21 13:23 ` [U-Boot] [Patch v3 2/2] net: asix: add support for AX88772B Lucas Stach
2012-08-21 18:19 ` Mike Frysinger [this message]
2012-08-21 18:16 ` [U-Boot] [Patch v3 1/2] net: introduce transparent driver private in ueth_data Mike Frysinger
2012-08-21 20:52 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208211419.24812.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.