All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Lee <adam8157@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Michal Marek <mmarek@suse.cz>, Sam Ravnborg <sam@ravnborg.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"open list:KCONFIG" <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c
Date: Wed, 22 Aug 2012 21:45:19 +0800	[thread overview]
Message-ID: <20120822134519.GA5639@adam-laptop> (raw)
In-Reply-To: <1345186649-17502-1-git-send-email-adam8157@gmail.com>

On Fri, Aug 17, 2012 at 02:57:28PM +0800, Adam Lee wrote:
> As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target
> 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but
> instead sets it to their default values.
> 
> This patch fixes the document in conf.c, and will submit another patch
> to replace 'oldnoconfig' to 'olddefconfig'
> 
> Signed-off-by: Adam Lee <adam8157@gmail.com>
> ---
>  scripts/kconfig/conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi,

I think we should apply this patch, any comment?

I was confused by the different documents of `make help` and usage of
"scripts/kconfig/conf.c" before I got through conf.c and checked the git
log. Others maybe confused too. So I think we really should apply this
patch at least.

As regards whether that target should be renamed to 'olddefconfig', we
can discuss it at another thread.

Thank you.

-- 
Regards,
Adam Lee
http://adam8157.info

  reply	other threads:[~2012-08-22 13:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17  6:57 [PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c Adam Lee
2012-08-17  6:57 ` Adam Lee
2012-08-22 13:45 ` Adam Lee [this message]
2012-08-31 14:57   ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120822134519.GA5639@adam-laptop \
    --to=adam8157@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.