From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default Date: Fri, 24 Aug 2012 10:42:31 +0100 Message-ID: <20120824094231.GA25765@n2100.arm.linux.org.uk> References: <20120718065951.GH6522@atomide.com> <20120718071039.GI6522@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org To: Peter Meerwald Cc: "Shilimkar, Santosh" , Javier Martinez Canillas , "S, Venkatraman" , Tony Lindgren , Javier Martinez Canillas , Kevin Hilman , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Ball , linux-mmc@vger.kernel.org List-Id: linux-mmc@vger.kernel.org On Fri, Aug 24, 2012 at 09:51:15AM +0200, Peter Meerwald wrote: > the commit just sets CONFIG_DMA_OMAP=y and CONFIG_DMADEVICES=y in > omap2plus_defconfig; this does not help people updating the kernel while > keeping the config, nor does it help people in configuring the kernel > > there is a dependency (at least for beagleboard) between MMC_OMAP_HS and > DMA_OMAP, and I think this should be made explicit Well, this is where stuff starts to get really yucky, because that means if you have DMA_OMAP as a module, you have to have MMC_OMAP_HS as a module too. Or vice versa. Which is a real pain for further development of DMA_OMAP. Whatever, the solution here is NOT to add select statements to the Kconfig to force DMA engine support and DMA_OMAP to 'y' for OMAP. The best solution is for MMC_OMAP_HS to depend on DMA_OMAP, but that will just mean that you'll end up with MMC_OMAP_HS disabled in your config witout DMA engine support. Another less desirable solution is to have MMC_OMAP_HS select DMA engine and DMA_OMAP. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Fri, 24 Aug 2012 10:42:31 +0100 Subject: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default In-Reply-To: References: <20120718065951.GH6522@atomide.com> <20120718071039.GI6522@atomide.com> Message-ID: <20120824094231.GA25765@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Aug 24, 2012 at 09:51:15AM +0200, Peter Meerwald wrote: > the commit just sets CONFIG_DMA_OMAP=y and CONFIG_DMADEVICES=y in > omap2plus_defconfig; this does not help people updating the kernel while > keeping the config, nor does it help people in configuring the kernel > > there is a dependency (at least for beagleboard) between MMC_OMAP_HS and > DMA_OMAP, and I think this should be made explicit Well, this is where stuff starts to get really yucky, because that means if you have DMA_OMAP as a module, you have to have MMC_OMAP_HS as a module too. Or vice versa. Which is a real pain for further development of DMA_OMAP. Whatever, the solution here is NOT to add select statements to the Kconfig to force DMA engine support and DMA_OMAP to 'y' for OMAP. The best solution is for MMC_OMAP_HS to depend on DMA_OMAP, but that will just mean that you'll end up with MMC_OMAP_HS disabled in your config witout DMA engine support. Another less desirable solution is to have MMC_OMAP_HS select DMA engine and DMA_OMAP.