From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4vrJ-0005yY-V1 for qemu-devel@nongnu.org; Fri, 24 Aug 2012 11:31:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4vrI-0001z3-KK for qemu-devel@nongnu.org; Fri, 24 Aug 2012 11:31:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4vrI-0001yx-Ar for qemu-devel@nongnu.org; Fri, 24 Aug 2012 11:31:40 -0400 Date: Fri, 24 Aug 2012 12:32:20 -0300 From: Luiz Capitulino Message-ID: <20120824123220.5793a9f6@doriath.home> In-Reply-To: References: <201208232109.q7NL9P9t016424@int-mx09.intmail.prod.int.phx2.redhat.com> <20120824111825.06484dd4@doriath.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "kwolf@redhat.com" , "aliguori@us.ibm.com" , "mst@redhat.com" , "jan.kiszka@siemens.com" , Jason Baron , "armbru@redhat.com" , "qemu-devel@nongnu.org" , "yamahata@valinux.co.jp" , "alex.williamson@redhat.com" , "pbonzini@redhat.com" , "afaerber@suse.de" On Fri, 24 Aug 2012 07:34:51 -0700 Alexander Graf wrote: > > > Am 24.08.2012 um 07:18 schrieb Luiz Capitulino : > > > On Thu, 23 Aug 2012 17:09:25 -0400 > > Jason Baron wrote: > > > >> While testing q35, I found that windows 7 (specifically, windows 7 ultimate > >> with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. > >> The failure message is: 'A required cd/dvd device driver is missing. If you > >> have a driver floppy disk, CD, DVD, or USB flash drive, please insert it now.' > >> This can also be reproduced on piix by adding an ahci controller, and > >> observing that windows 7 does not see any devices behind it. > >> > >> The problem is that when windows issues a HBA reset, qemu does not reset the > >> individual ports' PxCMD register. Windows 7 then reads back the PxCMD register > >> and presumably assumes that the ahci controller has already been initialized. > >> Windows then never sets up the PxIE register to enable interrupts, and thus it > >> never gets irqs back when it sends ata device inquiry commands. > >> > >> I believe this change brings qemu into ahci 1.3 specification compliance. > > > > I've tested this but unfortunately it doesn't fix the issues I'm getting with > > OpenBSD 5.1 and NetBSD 5.1 as reported here (section 'master with ahci'): > > > > http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03329.html > > > > PS: Those could be kernel issues, of course. > > The BSDs already fail in detecting the cotroller as a whole, right? Not just disks on it. Thanks for the clarification. Didn't try to understand the patch, automatically thought it could be related to my last testing report.