From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753759Ab2H2Nc5 (ORCPT ); Wed, 29 Aug 2012 09:32:57 -0400 Received: from mailrelay1.diasemi.com ([82.210.246.133]:2437 "EHLO mailrelay1.diasemi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753714Ab2H2Ncx (ORCPT ); Wed, 29 Aug 2012 09:32:53 -0400 From: Krystian Garbaciak To: Guenter Roeck CC: , , , , , , Samuel Ortiz , Liam Girdwood , Mark Brown , Alessandro Zummo , Jean Delvare , Dmitry Torokhov , Ashish Jangam , Andrew Jones , Donggeun Kim , Philippe =?iso-8859-1?Q?R=E9tornaz?= , "Wim Van Sebroeck" , Bryan Wu , Richard Purdie , Anthony Olech Subject: Re: [PATCH] regulator: Fix bug in regulator_mode_to_status() core function. References: <201208241500@sw-eng-lt-dc-vm2> <201208241505@sw-eng-lt-dc-vm2> <20120824184505.GA7275@roeck-us.net> In-Reply-To: <20120824184505.GA7275@roeck-us.net> Message-ID: <201208291425@sw-eng-lt-dc-vm2> Date: Wed, 29 Aug 2012 14:25:00 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static const struct i_table vsys_tbl[] = { > > + ILINE(0, DA906X_ADC_MAX, 2500, 5500) > > +}; > > + > > +static const struct i_table adcin_tbl[] = { > > + ILINE(0, DA906X_ADC_MAX, 0, 2500) > > +}; > > + > > +static const struct i_table tjunc_tbl[] = { > > + ILINE(0, DA906X_ADC_MAX, 333, -86) > > +}; > > + > > +static const struct i_table vbbat_tbl[] = { > > + ILINE(0, DA906X_ADC_MAX, 0, 5000) > > +}; > > Since the first parameter to ILINE is always 0, it is not needed. This means > that x0 in itable is also always 0 and thus not needed. > > > + > > +static const struct channel_info da906x_channels[] = { > > + [DA906X_VSYS] = { "VSYS", > > + vsys_tbl, ARRAY_SIZE(vsys_tbl) - 1, > > + DA906X_REG_VSYS_RES }, > > + [DA906X_ADCIN1] = { "ADCIN1", > > + adcin_tbl, ARRAY_SIZE(adcin_tbl) - 1, > > + DA906X_REG_ADCIN1_RES }, > > + [DA906X_ADCIN2] = { "ADCIN2", > > + adcin_tbl, ARRAY_SIZE(adcin_tbl) - 1, > > + DA906X_REG_ADCIN2_RES }, > > + [DA906X_ADCIN3] = { "ADCIN3", > > + adcin_tbl, ARRAY_SIZE(adcin_tbl) - 1, > > + DA906X_REG_ADCIN3_RES }, > > + [DA906X_TJUNC] = { "TJUNC", > > + tjunc_tbl, ARRAY_SIZE(tjunc_tbl) - 1 }, > > + [DA906X_VBBAT] = { "VBBAT", > > + vbbat_tbl, ARRAY_SIZE(vbbat_tbl) - 1} > > s/1}/1 }/ > > > +}; > > You lost me here a bit (I am missing something ?). > > Seems to be each table has exactly one entry. Since the table size is 1, > ARRAY_SIZE(vbbat_tbl) - 1 is 0, and ... An initial idea was to make the interpolation of the channel values using more ILINE segments. Eventually, it ended up with one linear segment for every channel, so it makes sense to reduce the code as you propose. As suggested, driver name will be changed from "da906x" to "da9063". I will adapt proposed changes and fixes. Thank you for your comments, Krystian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krystian Garbaciak Date: Wed, 29 Aug 2012 13:25:00 +0000 Subject: Re: [lm-sensors] [PATCH] regulator: Fix bug in regulator_mode_to_status() core function. Message-Id: <201208291425@sw-eng-lt-dc-vm2> List-Id: References: <201208241500@sw-eng-lt-dc-vm2> <201208241505@sw-eng-lt-dc-vm2> <20120824184505.GA7275@roeck-us.net> In-Reply-To: <20120824184505.GA7275@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, lm-sensors@lm-sensors.org, linux-input@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-leds@vger.kernel.org, Samuel Ortiz , Liam Girdwood , Mark Brown , Alessandro Zummo , Jean Delvare , Dmitry Torokhov , Ashish Jangam , Andrew Jones , Donggeun Kim , Philippe =?iso-8859-1?Q?R=E9tornaz?= , Wim Van Sebroeck , Bryan Wu , Richard Purdie , Anthony Olech > +static const struct i_table vsys_tbl[] = { > > + ILINE(0, DA906X_ADC_MAX, 2500, 5500) > > +}; > > + > > +static const struct i_table adcin_tbl[] = { > > + ILINE(0, DA906X_ADC_MAX, 0, 2500) > > +}; > > + > > +static const struct i_table tjunc_tbl[] = { > > + ILINE(0, DA906X_ADC_MAX, 333, -86) > > +}; > > + > > +static const struct i_table vbbat_tbl[] = { > > + ILINE(0, DA906X_ADC_MAX, 0, 5000) > > +}; > > Since the first parameter to ILINE is always 0, it is not needed. This means > that x0 in itable is also always 0 and thus not needed. > > > + > > +static const struct channel_info da906x_channels[] = { > > + [DA906X_VSYS] = { "VSYS", > > + vsys_tbl, ARRAY_SIZE(vsys_tbl) - 1, > > + DA906X_REG_VSYS_RES }, > > + [DA906X_ADCIN1] = { "ADCIN1", > > + adcin_tbl, ARRAY_SIZE(adcin_tbl) - 1, > > + DA906X_REG_ADCIN1_RES }, > > + [DA906X_ADCIN2] = { "ADCIN2", > > + adcin_tbl, ARRAY_SIZE(adcin_tbl) - 1, > > + DA906X_REG_ADCIN2_RES }, > > + [DA906X_ADCIN3] = { "ADCIN3", > > + adcin_tbl, ARRAY_SIZE(adcin_tbl) - 1, > > + DA906X_REG_ADCIN3_RES }, > > + [DA906X_TJUNC] = { "TJUNC", > > + tjunc_tbl, ARRAY_SIZE(tjunc_tbl) - 1 }, > > + [DA906X_VBBAT] = { "VBBAT", > > + vbbat_tbl, ARRAY_SIZE(vbbat_tbl) - 1} > > s/1}/1 }/ > > > +}; > > You lost me here a bit (I am missing something ?). > > Seems to be each table has exactly one entry. Since the table size is 1, > ARRAY_SIZE(vbbat_tbl) - 1 is 0, and ... An initial idea was to make the interpolation of the channel values using more ILINE segments. Eventually, it ended up with one linear segment for every channel, so it makes sense to reduce the code as you propose. As suggested, driver name will be changed from "da906x" to "da9063". I will adapt proposed changes and fixes. Thank you for your comments, Krystian _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors