From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit Date: Tue, 4 Sep 2012 17:56:10 +0200 Message-ID: <20120904175610.2c2934f1@skate> References: <1346764004-16332-1-git-send-email-thomas.petazzoni@free-electrons.com> <1346764004-16332-2-git-send-email-thomas.petazzoni@free-electrons.com> <201209041436.36430.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Lior Amsalem , Andrew Lunn , Ike Pan , Nadav Haklai , Ian Molton , Lennert Buytenhek , David Marlin , Rami Rosen , Yehuda Yitschak , Jani Monoses , Tawfik Bayouk , Dan Frazier , Eran Ben-Avi , Li Li , Leif Lindholm , Sebastian Hesselbarth , Jason Cooper , Jon Masters , Ben Dooks , Gregory Clement , linux-arm-kernel@lists.infradead.org, Chris Van Hoof , Nicolas Pitre , netdev@vger.k To: Arnd Bergmann Return-path: In-Reply-To: <201209041436.36430.arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org QXJuZCwKClRoYW5rcyBmb3IgbG9va2luZyBzbyBxdWlja2x5IGludG8gdGhpcyBkcml2ZXIhCgpM ZSBUdWUsIDQgU2VwIDIwMTIgMTQ6MzY6MzYgKzAwMDAsCkFybmQgQmVyZ21hbm4gPGFybmRAYXJu ZGIuZGU+IGEgw6ljcml0IDoKCj4gT24gVHVlc2RheSAwNCBTZXB0ZW1iZXIgMjAxMiwgVGhvbWFz IFBldGF6em9uaSB3cm90ZToKPiA+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvbWFydmVs bC1uZXRhLnR4dCAgICAgICB8ICAgMjQgKwo+ID4gIGRyaXZlcnMvbmV0L2V0aGVybmV0L21hcnZl bGwvS2NvbmZpZyAgICAgICAgICAgICAgIHwgICAxMSArCj4gPiAgZHJpdmVycy9uZXQvZXRoZXJu ZXQvbWFydmVsbC9NYWtlZmlsZSAgICAgICAgICAgICAgfCAgICAxICsKPiA+ICBkcml2ZXJzL25l dC9ldGhlcm5ldC9tYXJ2ZWxsL212bmV0YS5jICAgICAgICAgICAgICB8IDI3MzIgKysrKysrKysr KysrKysrKysrKysKPiA+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9tYXJ2ZWxsL212bmV0YS5oICAg ICAgICAgICAgICB8ICA0OTYgKysrKwo+ID4gIDUgZmlsZXMgY2hhbmdlZCwgMzI2NCBpbnNlcnRp b25zKCspCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9uZXQvbWFydmVsbC1uZXRhLnR4dAo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2 ZXJzL25ldC9ldGhlcm5ldC9tYXJ2ZWxsL212bmV0YS5jCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGRyaXZlcnMvbmV0L2V0aGVybmV0L21hcnZlbGwvbXZuZXRhLmgKPiAKPiBJIHVzdWFsbHkgcHJl ZmVyIHB1dHRpbmcgdGhlIGRlZmluaXRpb25zIGludG8gdGhlIC5jIGZpbGUgcmF0aGVyCj4gdGhh biBhIHNlcGFyYXRlIGhlYWRlciBpZiB0aGVyZSBpcyBvbmx5IG9ubHkgZmlsZSBpbmNsdWRpbmcg aXQKPiBhbnl3YXkuCgpGaW5lLiBJIGhlc2l0YXRlZCBvbiB0aGlzIG9uZSwgYnV0IHNpbmNlIHRo ZSBkcml2ZXIgd2FzIGFscmVhZHkgcXVpdGUKbG9uZywgSSB0aG91Z2h0IGEgc2VwYXJhdGUgaGVh ZGVyIHdvdWxkIGJlIG5pY2VyLCBidXQgSSBkb24ndCBoYXZlIGEKc3Ryb25nIG9waW5pb24sIHNv IEknbGwgcmVzdWJtaXQgd2l0aCB0aGlzIGNoYW5nZS4KCj4gPiArZXRoQGQwMDcwMDAwIHsKPiA+ ICsgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm1hcnZlbGwsbmV0YSI7Cj4gPiArICAgICAg ICAgICAgICAgcmVnID0gPDB4ZDAwNzAwMDAgMHgyNTAwPjsKPiA+ICsgICAgICAgICAgICAgICBp bnRlcnJ1cHRzID0gPDg+Owo+ID4gKyAgICAgICAgICAgICAgIGRldmljZV90eXBlID0gIm5ldHdv cmsiOwo+ID4gKyAgICAgICAgICAgICAgIGNsb2NrLWZyZXF1ZW5jeSA9IDwyNTAwMDAwMDA+Owo+ ID4gKyAgICAgICAgICAgICAgIHN0YXR1cyA9ICJva2F5IjsKPiA+ICsgICAgICAgICAgICAgICBw aHktbW9kZSA9ICJzZ21paSI7Cj4gPiArICAgICAgICAgICAgICAgcGh5LWFkZHIgPSA8MjU+Owo+ IAo+IEkgdGhpbmsgd2Ugbm9ybWFsbHkgcHV0IHRoZSBwaHkgaW50byBhIHNlcGFyYXRlIGRldmlj ZSBub2RlIG9uIGFuCj4gbWRpbyBidXMgYW5kIHRoZW4gdXNlIHRoZSBvZl9waHlfKiBmdW5jdGlv bnMgdG8gY29ubmVjdCBpdCB0bwo+IHRoZSBldGhlcm5ldCBkZXZpY2UuCgpFdmVuIHRob3VnaCBp dCBtYXkgbm90IGJlIGEgY29udmluY2luZyBhcmd1bWVudCwgbm9uZSBvZiB0aGUgZXhpc3Rpbmcg RFQKZmlsZXMgaW4gYXJjaC9hcm0vYm9vdC9kdHMgc2VlbSB0byBpbnN0YW50aWF0ZSBhIHNlcGFy YXRlIFBIWSBkZXZpY2UKYW5kIGEgcHJvcGVyIE1ESU8gYnVzLiBIb3dldmVyLCB0aGUgUG93ZXJQ QyBwbGF0Zm9ybXMgaW5kZWVkIG1ha2UgdGhpcwpkaXN0aW5jdGlvbiBhIGxvdCBjbGVhcmVyLgoK SG93ZXZlciwgdGhpcyBuZXR3b3JrIHVuaXQgaGFzIGEgY2xldmVyIE1BQyB0aGF0IGF1dG9ub21v dXNseSBxdWVyaWVzCnRoZSBQSFkgZm9yIHRoZSBsaW5rIHN0YXR1cywgYW5kIHJlcG9ydHMgY2hh bmdlcyAobGluaywgZHVwbGV4LCBzcGVlZCkKaW4gdGhlIGZvcm0gb2YgTUFDIGludGVycnVwdHMg YW5kIE1BQyByZWdpc3RlcnMuIFRoZXJlZm9yZSwgZm9yIGJhc2ljCm9wZXJhdGlvbiwgdGhlcmUg aXMgbm8gbmVlZCBmb3IgYSBzZXBhcmF0ZSBQSFkgZHJpdmVyIG5vciB0byBleHBvc2UgdGhlCk1E SU8gYnVzIGluIGFueSB3YXkuIFRoZSBvbmx5IHRoaW5nIG5lZWRlZCBpcyB0aGUgUEhZIGFkZHJl c3MsIHdoaWNoIGlzCmZpbGxlZCBpbnRvIGEgcmVnaXN0ZXIgb2YgdGhlIE1BQyBzbyB0aGF0IGl0 IGNhbiBzdGFydCBpdHMgYXV0b21hdGljCnF1ZXJ5IG9mIHRoZSBQSFkuCgpLbm93aW5nIHRoaXMs IHdvdWxkIGl0IGJlIGFjY2VwdGFibGUgdG8gaGF2ZSB0aGlzIGRyaXZlciB3aXRob3V0IGFuCmV4 cGxpY2l0IE1ESU8gYnVzIGluIHRoZSBEVD8KClRoYW5rcywKClRob21hcwotLSAKVGhvbWFzIFBl dGF6em9uaSwgRnJlZSBFbGVjdHJvbnMKS2VybmVsLCBkcml2ZXJzLCByZWFsLXRpbWUgYW5kIGVt YmVkZGVkIExpbnV4CmRldmVsb3BtZW50LCBjb25zdWx0aW5nLCB0cmFpbmluZyBhbmQgc3VwcG9y dC4KaHR0cDovL2ZyZWUtZWxlY3Ryb25zLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Tue, 4 Sep 2012 17:56:10 +0200 Subject: [PATCH 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit In-Reply-To: <201209041436.36430.arnd@arndb.de> References: <1346764004-16332-1-git-send-email-thomas.petazzoni@free-electrons.com> <1346764004-16332-2-git-send-email-thomas.petazzoni@free-electrons.com> <201209041436.36430.arnd@arndb.de> Message-ID: <20120904175610.2c2934f1@skate> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Arnd, Thanks for looking so quickly into this driver! Le Tue, 4 Sep 2012 14:36:36 +0000, Arnd Bergmann a ?crit : > On Tuesday 04 September 2012, Thomas Petazzoni wrote: > > .../devicetree/bindings/net/marvell-neta.txt | 24 + > > drivers/net/ethernet/marvell/Kconfig | 11 + > > drivers/net/ethernet/marvell/Makefile | 1 + > > drivers/net/ethernet/marvell/mvneta.c | 2732 ++++++++++++++++++++ > > drivers/net/ethernet/marvell/mvneta.h | 496 ++++ > > 5 files changed, 3264 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/marvell-neta.txt > > create mode 100644 drivers/net/ethernet/marvell/mvneta.c > > create mode 100644 drivers/net/ethernet/marvell/mvneta.h > > I usually prefer putting the definitions into the .c file rather > than a separate header if there is only only file including it > anyway. Fine. I hesitated on this one, but since the driver was already quite long, I thought a separate header would be nicer, but I don't have a strong opinion, so I'll resubmit with this change. > > +eth at d0070000 { > > + compatible = "marvell,neta"; > > + reg = <0xd0070000 0x2500>; > > + interrupts = <8>; > > + device_type = "network"; > > + clock-frequency = <250000000>; > > + status = "okay"; > > + phy-mode = "sgmii"; > > + phy-addr = <25>; > > I think we normally put the phy into a separate device node on an > mdio bus and then use the of_phy_* functions to connect it to > the ethernet device. Even though it may not be a convincing argument, none of the existing DT files in arch/arm/boot/dts seem to instantiate a separate PHY device and a proper MDIO bus. However, the PowerPC platforms indeed make this distinction a lot clearer. However, this network unit has a clever MAC that autonomously queries the PHY for the link status, and reports changes (link, duplex, speed) in the form of MAC interrupts and MAC registers. Therefore, for basic operation, there is no need for a separate PHY driver nor to expose the MDIO bus in any way. The only thing needed is the PHY address, which is filled into a register of the MAC so that it can start its automatic query of the PHY. Knowing this, would it be acceptable to have this driver without an explicit MDIO bus in the DT? Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com