All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <greg@kroah.com>
To: Toshiaki Yamane <yamanetoshi@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging/rts_pstor: Use pr_ printks in debug.h
Date: Tue, 4 Sep 2012 12:26:14 -0700	[thread overview]
Message-ID: <20120904192614.GB13081@kroah.com> (raw)
In-Reply-To: <1346203816-5975-1-git-send-email-yamanetoshi@gmail.com>

On Wed, Aug 29, 2012 at 10:30:15AM +0900, Toshiaki Yamane wrote:
> fixed below checkpatch warnings.
> -WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...

No, please use dev_dbg() instead.

thanks,

greg k-h

  reply	other threads:[~2012-09-04 19:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29  1:29 [PATCH 1/2] staging/rts_pstor: Use pr_ printks in rtsx.c Toshiaki Yamane
2012-08-29  1:30 ` [PATCH 2/2] staging/rts_pstor: Use pr_ printks in debug.h Toshiaki Yamane
2012-09-04 19:26   ` Greg Kroah-Hartman [this message]
2012-09-04 19:25 ` [PATCH 1/2] staging/rts_pstor: Use pr_ printks in rtsx.c Greg Kroah-Hartman
2012-09-16  7:26 ` [PATCH] staging/rts_pstor: Use pr_ or dev_ " Toshiaki Yamane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120904192614.GB13081@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamanetoshi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.