From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Wed, 5 Sep 2012 00:28:16 +0300 Message-ID: <20120904212816.GE3602@redhat.com> References: <503C74DD.3020307@msgid.tls.msk.ru> <20120828172838.GD3661@redhat.com> <87fw76ak5l.fsf@codemonkey.ws> <878vcyrtlz.fsf@blackfin.pond.sub.org> <5044D75A.3000406@redhat.com> <5045BC96.5070806@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Marcelo Tosatti , Michael Tokarev , Markus Armbruster , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka , Avi Kivity , Anthony Liguori To: Blue Swirl Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On Tue, Sep 04, 2012 at 07:27:32PM +0000, Blue Swirl wrote: > On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: > > On 09/03/2012 10:32 PM, Blue Swirl wrote: > >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: > >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: > >>>> > >>>> I don't see a point in making contributors avoid non-problems that might > >>>> conceivably become trivial problems some day. Especially when there's > >>>> no automated help with the avoiding. > >>> > >>> -Wpointer-arith > >> > >> +1 > > > > FWIW, I'm not in favour of enabling it, just pointing out that it > > exists. In general I prefer avoiding unnecessary use of extensions, but > > in this case the extension is trivial and improves readability. > > Void pointers are not so type safe as uint8_t pointers. casts are even worse. > There's also > little difference in readability between those in my opinion. here too, casts are worse for readability. > > > > > > -- > > error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T90eG-0001hZ-Ck for qemu-devel@nongnu.org; Tue, 04 Sep 2012 17:27:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T90eE-00068g-26 for qemu-devel@nongnu.org; Tue, 04 Sep 2012 17:27:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T90eD-00068V-QB for qemu-devel@nongnu.org; Tue, 04 Sep 2012 17:27:01 -0400 Date: Wed, 5 Sep 2012 00:28:16 +0300 From: "Michael S. Tsirkin" Message-ID: <20120904212816.GE3602@redhat.com> References: <503C74DD.3020307@msgid.tls.msk.ru> <20120828172838.GD3661@redhat.com> <87fw76ak5l.fsf@codemonkey.ws> <878vcyrtlz.fsf@blackfin.pond.sub.org> <5044D75A.3000406@redhat.com> <5045BC96.5070806@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: kvm@vger.kernel.org, Marcelo Tosatti , Michael Tokarev , Markus Armbruster , qemu-devel@nongnu.org, Alex Williamson , Jan Kiszka , Avi Kivity , Anthony Liguori On Tue, Sep 04, 2012 at 07:27:32PM +0000, Blue Swirl wrote: > On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: > > On 09/03/2012 10:32 PM, Blue Swirl wrote: > >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: > >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: > >>>> > >>>> I don't see a point in making contributors avoid non-problems that might > >>>> conceivably become trivial problems some day. Especially when there's > >>>> no automated help with the avoiding. > >>> > >>> -Wpointer-arith > >> > >> +1 > > > > FWIW, I'm not in favour of enabling it, just pointing out that it > > exists. In general I prefer avoiding unnecessary use of extensions, but > > in this case the extension is trivial and improves readability. > > Void pointers are not so type safe as uint8_t pointers. casts are even worse. > There's also > little difference in readability between those in my opinion. here too, casts are worse for readability. > > > > > > -- > > error compiling committee.c: too many arguments to function