All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: Export nd_tbl to allow modules to support IPv6
Date: Wed, 05 Sep 2012 13:06:36 -0400 (EDT)	[thread overview]
Message-ID: <20120905.130636.2295422323329670307.davem@davemloft.net> (raw)
In-Reply-To: <fd8b9a9ad300edfc378065ef7887c3debeeb5e89.1346843399.git.tgraf@suug.ch>

From: Thomas Graf <tgraf@suug.ch>
Date: Wed,  5 Sep 2012 13:14:08 +0200

> It does not make sense to export these functions if we don't
> export the table itself as well.

Yes it does make perfect sense.  It's exported for the sake of the
_implementation_ of a neighbour table in a kernel module.

I do not want to add more users with direct access to the neighbour
tables, because it is therefore impossible to go and add the inline
refcount'less lookups et al. to those external users.

So if one of our goals is to move towards a situation where all neigh
accesses are refcount'less, having those external users makes that
nearly impossible.

Instead, I'd rather see patches that mark arp_tbl as being exported
only for internal usage inside of the tree, so that we can reach that
goal.

I'm not applying this, sorry.

  reply	other threads:[~2012-09-05 17:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 11:14 [PATCH net-next] ipv6: Export nd_tbl to allow modules to support IPv6 Thomas Graf
2012-09-05 17:06 ` David Miller [this message]
2012-09-06  8:51   ` Thomas Graf
2012-09-06 17:47     ` David Miller
2012-09-06 21:06       ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120905.130636.2295422323329670307.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.