From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] Xen backend support for paged out grant targets. Date: Wed, 5 Sep 2012 12:27:31 -0400 Message-ID: <20120905162731.GD11949@phenom.dumpdata.com> References: <1346086287-17674-1-git-send-email-andres@lagarcavilla.org> <5040CAEA.7000600@citrix.com> <160CC375-2682-4CBF-B1EC-06A9F3E49A40@gridcentric.ca> <5040E210.2060702@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5040E210.2060702@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: Andres Lagar-Cavilla , Andres Lagar-Cavilla , "andres@lagarcavilla.org" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Fri, Aug 31, 2012 at 05:10:56PM +0100, David Vrabel wrote: > On 31/08/12 16:42, Andres Lagar-Cavilla wrote: > > Actually acted upon your feedback ipso facto: > > > > commit d5fab912caa1f0cf6be0a6773f502d3417a207b6 > > Author: Andres Lagar-Cavilla > > Date: Sun Aug 26 09:45:57 2012 -0400 > > > > Xen backend support for paged out grant targets. > > This looks mostly fine expect for the #define instead of inline functions. > > > +#define gnttab_map_grant_no_eagain(_gop) \ > > This name tripped me up previously. As I read this as: > > gnttab_map_grant_no_[retries_for]_eagain(). > > Perhaps gnttab_map_grant_with_retries() ? Or similar? gnttab_map_grant_retry ? Besides that, it looks good to me. Ian Campbell needs to Ack so that David Miller (the network maintainer) can pick it up. Please CC them both and also LKML. > > David