From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 5/9] ARM: OMAP2+: Remove hardcoded twl4030 gpio_base, irq_base and irq_end Date: Wed, 5 Sep 2012 09:54:45 -0700 Message-ID: <20120905165445.GD1303@atomide.com> References: <20120831004828.28732.902.stgit@muffinssi.local> <20120831005230.28732.1131.stgit@muffinssi.local> <20120831235212.GS1303@atomide.com> <50474FC0.6010805@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:21843 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752789Ab2IEQyu (ORCPT ); Wed, 5 Sep 2012 12:54:50 -0400 Content-Disposition: inline In-Reply-To: <50474FC0.6010805@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Peter Ujfalusi Cc: linux-arm-kernel@lists.infradead.org, Grant Likely , Linus Walleij , linux-omap@vger.kernel.org, Samuel Ortiz * Peter Ujfalusi [120905 06:12]: > Hi Tony, > > On 09/01/2012 02:52 AM, Tony Lindgren wrote: > > > > ..but irq_base here is still in use as that's where the value from > > irq_alloc_descs() is being stored to. So I'll drop the changes to > > struct twl6040 from this patch as otherwise twl6040 code won't compile. > > > > Turns out I did not have twl6040 selected in any of the testconfigs > > that I ran. > > I store the irq_base in a private data for the MFD driver so child drivers can > request the correct IRQ. > > You can safely remove the irq_base from twl6040_platform_data struct Can you please do a patch for that against testing-cleanup branch? That way we'll know that the twl changes get tested for audio ;) Maybe also check if Felipe's earlier patch also has something else that can be removed? That's the "[PATCH] arm: omap: drop unused IRQ defines": http://lists.infradead.org/pipermail/linux-arm-kernel/2012-June/103274.html# Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 5 Sep 2012 09:54:45 -0700 Subject: [PATCH 5/9] ARM: OMAP2+: Remove hardcoded twl4030 gpio_base, irq_base and irq_end In-Reply-To: <50474FC0.6010805@ti.com> References: <20120831004828.28732.902.stgit@muffinssi.local> <20120831005230.28732.1131.stgit@muffinssi.local> <20120831235212.GS1303@atomide.com> <50474FC0.6010805@ti.com> Message-ID: <20120905165445.GD1303@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Peter Ujfalusi [120905 06:12]: > Hi Tony, > > On 09/01/2012 02:52 AM, Tony Lindgren wrote: > > > > ..but irq_base here is still in use as that's where the value from > > irq_alloc_descs() is being stored to. So I'll drop the changes to > > struct twl6040 from this patch as otherwise twl6040 code won't compile. > > > > Turns out I did not have twl6040 selected in any of the testconfigs > > that I ran. > > I store the irq_base in a private data for the MFD driver so child drivers can > request the correct IRQ. > > You can safely remove the irq_base from twl6040_platform_data struct Can you please do a patch for that against testing-cleanup branch? That way we'll know that the twl changes get tested for audio ;) Maybe also check if Felipe's earlier patch also has something else that can be removed? That's the "[PATCH] arm: omap: drop unused IRQ defines": http://lists.infradead.org/pipermail/linux-arm-kernel/2012-June/103274.html# Regards, Tony