From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 00/58] modeset-rework, the basic conversion Date: Thu, 6 Sep 2012 18:08:42 -0700 Message-ID: <20120906180842.77758a9a@jbarnes-desktop> References: <1345403595-9678-1-git-send-email-daniel.vetter@ffwll.ch> <20120905162355.3d7fe823@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id 6511D9EB3D for ; Thu, 6 Sep 2012 18:08:43 -0700 (PDT) In-Reply-To: <20120905162355.3d7fe823@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, 5 Sep 2012 16:23:55 -0700 Jesse Barnes wrote: > On Sun, 19 Aug 2012 21:12:17 +0200 > Daniel Vetter wrote: > > > Hi all, > > > > Changes since last time around: > > - The prep patches are all merged now. > > - I've left out the actual DP fixes/cleanups, I think we should merge those in a > > separte step. > > - A few bugfixes (thanks to Paulo, Jani and Chris). > > - I've also applied a few bikesheds for naming that Paulo suggested (but I'm not > > sure whether I've sent those out already in a previous patchbomb). > > > > Essentially this is just the core rework, which addes the new get_hw_state code, > > refactors all the encoders to use the new functions and finally reworks the > > modeset logic to disable/enable entire pipes, always (and with a deterministic > > order). > > > > For merging to -next, I plan to pull in everything with a real merge commit. For > > that reason I've put up a modeset-rework-base branch onto my private fdo repo[1]. > > That way I can put a short documentation for the new modeset design into the > > merge commit (stichted together from the previous patchbomb cover letters), > > documenting my folly assumptions for eternity. > > > > I'll also plan to put tags for the entire series in the merge commit, so if you > > have tested this on a few machines, read through and agree with the new designs, > > please reply with your tested-by/acked-by/reviewed-by tags. > > > > Flames, comments and test reports highly welcome. > > Ok I've tested on Ironlake, Cantiga, Crestline, and Pineview so far and > things look good. I ran testdisplay both with and without VGA > attached (the ILK has a eDP panel), and tried S3 and S4 both with and > without VGA both in the console and in X. > > There was one issue on Pineview where the VGA seemed to get > "forgotten", but I haven't isolated it yet. I canceled testdisplay > part way through and that seemed to confuse fbcon about what was there. > > I also see an issue with 1280x800 modes across all platforms, but that > may just be the monitor, I need to test more. > > I'm testing Montara (that's 855 for you youngsters) now, but it's slow > so not all my builds have completed there yet. > > Overall though: > Tested-by: Jesse Barnes > Looks like I just found an issue with DPMS on fbcon on SNB though. Leaving the system for awhile either results in corruption (part of the fbcon on the screen) or just the screen left on. This is on LVDS. -- Jesse Barnes, Intel Open Source Technology Center