From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 03/13] xfs: rationalise xfs_mount_wq users
Date: Fri, 7 Sep 2012 10:41:25 +1000 [thread overview]
Message-ID: <20120907004125.GS15292@dastard> (raw)
In-Reply-To: <5048BC7F.3060607@sgi.com>
On Thu, Sep 06, 2012 at 10:08:47AM -0500, Mark Tinguely wrote:
> I misspoke, it is xfs test 179. I hit it doing a "check -g auto".
>
> My test boxes had CONFIG_XFS_DEBUG=y which may be a factor. The
> test ran fine on a box without the debug enabled and assert as
> soon as I added it back.
It is - the assert doesn't exist on a non-DEBUG kernel, so it won't
fail. ;)
> The buffer with zero b_hold count is the freelist buffer (XAGF)
> for AG0. The buffer is marked STALE, it has already gone through
> the release code, so there is no transaction pointer nor log item
> pointer. The xlog_cil_committed() is being called with the
> XFS_LI_ABORTED flag.
It looks like another case of this problem:
http://oss.sgi.com/archives/xfs/2012-09/msg00021.html
Which appears to be another case of the failure that Eric reported
he was seeing on test 137:
http://oss.sgi.com/archives/xfs/2012-08/msg00019.html
http://oss.sgi.com/archives/xfs/2012-09/msg00017.html
i.e. what appears to be a double free of a buffer during a forced
shutdown. The b_hold assertion that is being hit here is just prior
to doing the second free of a buffer. Given that Eric's case was
bisected down to the delwri queuing changes, I'd say this is the
same cause of this issue. i.e. unrelated to the patch set that was
posted.
What I can't work out is what reference is going missing, and I
can't reproduce it to be able to debug it....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-07 0:40 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 12:00 [PATCH V2 00/13] xfs: remove the xfssyncd mess Dave Chinner
2012-08-30 12:00 ` [PATCH 01/13] xfs: xfs_syncd_stop must die Dave Chinner
2012-09-01 23:15 ` Christoph Hellwig
2012-09-04 16:10 ` Mark Tinguely
2012-08-30 12:00 ` [PATCH 02/13] xfs: rename the xfs_syncd workqueue Dave Chinner
2012-09-01 23:17 ` Christoph Hellwig
2012-09-03 3:09 ` Dave Chinner
2012-08-30 12:00 ` [PATCH 03/13] xfs: rationalise xfs_mount_wq users Dave Chinner
2012-09-04 15:48 ` Mark Tinguely
2012-09-05 4:30 ` Dave Chinner
2012-09-05 13:16 ` Mark Tinguely
2012-09-05 14:34 ` Mark Tinguely
2012-09-06 0:46 ` Dave Chinner
2012-09-06 15:08 ` Mark Tinguely
2012-09-07 0:41 ` Dave Chinner [this message]
2012-09-11 21:25 ` Mark Tinguely
2012-08-30 12:00 ` [PATCH 04/13] xfs: don't run the sync work if the filesyste is read-only Dave Chinner
2012-09-04 16:13 ` Mark Tinguely
2012-08-30 12:00 ` [PATCH 05/13] xfs: sync work is now only periodic log work Dave Chinner
2012-09-01 23:23 ` Christoph Hellwig
2012-09-03 3:36 ` Dave Chinner
2012-09-04 16:14 ` Mark Tinguely
2012-09-04 18:57 ` Mark Tinguely
2012-09-05 4:35 ` Dave Chinner
2012-08-30 12:00 ` [PATCH 06/13] xfs: Bring some sanity to log unmounting Dave Chinner
2012-09-01 23:28 ` Christoph Hellwig
2012-09-04 19:11 ` Mark Tinguely
2012-08-30 12:00 ` [PATCH 07/13] xfs: xfs_sync_data is redundant Dave Chinner
2012-09-01 23:24 ` Christoph Hellwig
2012-09-03 6:08 ` Dave Chinner
2012-09-04 20:48 ` Mark Tinguely
2012-09-06 0:53 ` Dave Chinner
2012-08-30 12:00 ` [PATCH 08/13] xfs: xfs_sync_fsdata " Dave Chinner
2012-09-01 23:27 ` Christoph Hellwig
2012-09-04 20:59 ` Mark Tinguely
2012-08-30 12:00 ` [PATCH 09/13] xfs: move xfs_quiesce_attr() into xfs_super.c Dave Chinner
2012-09-01 23:27 ` Christoph Hellwig
2012-09-04 21:03 ` Mark Tinguely
2012-08-30 12:00 ` [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like unmount Dave Chinner
2012-09-01 23:29 ` Christoph Hellwig
2012-09-04 21:04 ` Mark Tinguely
2012-08-30 12:00 ` [PATCH 11/13] xfs: rename xfs_sync.[ch] to xfs_icache.[ch] Dave Chinner
2012-09-01 23:30 ` Christoph Hellwig
2012-09-04 21:06 ` Mark Tinguely
2012-08-30 12:00 ` [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c Dave Chinner
2012-09-01 23:30 ` Christoph Hellwig
2012-09-04 21:07 ` Mark Tinguely
2012-08-30 12:00 ` [PATCH 13/13] xfs: remove xfs_iget.c Dave Chinner
2012-09-01 23:31 ` Christoph Hellwig
2012-09-04 21:11 ` Mark Tinguely
2012-08-30 12:15 ` [PATCH V2 00/13] xfs: remove the xfssyncd mess Markus Trippelsdorf
2012-08-30 22:51 ` Dave Chinner
2012-08-31 6:18 ` Markus Trippelsdorf
2012-08-31 8:42 ` Dave Chinner
2012-08-31 9:30 ` Markus Trippelsdorf
2012-08-31 14:01 ` Mark Tinguely
2012-09-03 4:05 ` Dave Chinner
2012-09-04 0:13 ` Mark Tinguely
2012-09-25 9:26 ` Christoph Hellwig
2012-09-25 9:35 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2012-08-30 10:57 [PATCH " Dave Chinner
2012-08-30 10:57 ` [PATCH 03/13] xfs: rationalise xfs_mount_wq users Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907004125.GS15292@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.