From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223Ab2IPSlI (ORCPT ); Sun, 16 Sep 2012 14:41:08 -0400 Received: from na3sys009aog132.obsmtp.com ([74.125.149.250]:40791 "EHLO na3sys009aog132.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738Ab2IPSlF (ORCPT ); Sun, 16 Sep 2012 14:41:05 -0400 Date: Sun, 16 Sep 2012 21:36:22 +0300 From: Felipe Balbi To: Paul Walmsley Cc: Felipe Balbi , Shubhrajyoti Datta , Greg KH , alan@linux.intel.com, Tony Lindgren , Kevin Hilman , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , linux-serial@vger.kernel.org, Linux Kernel Mailing List , Santosh Shilimkar , Sourav Poddar Subject: Re: [PATCH v4 00/21] OMAP UART Patches Message-ID: <20120916183620.GA30189@arwen.pp.htv.fi> Reply-To: balbi@ti.com References: <20120906122948.GC29202@arwen.pp.htv.fi> <1346935540-1792-1-git-send-email-balbi@ti.com> <20120912062259.GC18563@arwen.pp.htv.fi> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Sep 16, 2012 at 01:22:01AM +0000, Paul Walmsley wrote: > On Wed, 12 Sep 2012, Felipe Balbi wrote: >=20 > > On Tue, Sep 11, 2012 at 10:02:48PM +0000, Paul Walmsley wrote: > >=20 > > > The bad news is that N800 no longer boots -- or the UART dies during= =20 > > > serial init: > > >=20 > > > http://www.pwsan.com/omap/testlogs/test_tty_next_e36851d0/20120910020= 323/boot/2420n800/2420n800_log.txt > > >=20 > > > The problem doesn't seem to affect the 2430SDP. > > >=20 > > > Could you put together a patch to fix N800? >=20 > Bisected this down. It's this one that causes the problem on N800: >=20 > commit 93220dcc3052182e7156c09655ad1316055564b9 > Author: Felipe Balbi > Date: Thu Sep 6 15:45:27 2012 +0300 >=20 > serial: omap: set dev->drvdata before enabling pm_runtime > =20 > by the time we call our first pm_runtme_get_sync() > after enable pm_runtime, our resume method might > be called. To avoid problems, we must make sure > that our dev->drvdata is set correctly before > our resume method gets called. > =20 > Tested-by: Shubhrajyoti D > Acked-by: Santosh Shilimkar > Signed-off-by: Felipe Balbi > Signed-off-by: Greg Kroah-Hartman Interesting. That simply moves platform_set_drvdata() to a saner location... The only way for this to cause problems is if we're trying to restore a context which was never saved. Is there a way to prevent runtime_resume() to be called during probe() if I know the HW is already enabled ? Maybe with pm_runtime_set_active() ? --=20 balbi --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQVhwkAAoJEIaOsuA1yqREVJYP/jqYh5vUZOh5Fq/rEsortJiY baO1XAXccZhNqo8TyyEqMqMYqA+AtIrj5DROl8ZhBChsxwkKqgvHq/gaAhYMVnq5 r4LboEbQ17EkJQAIwouTVBVsRpm/IP83bNpLl1dLCIVXMjIXUx6QAXFkIae9iwa9 j9yTKzjYp7YFdmAINE6kvkoiDtrzu0qMBmUwqHklTqWGEU6xoZRG2QGXuPYWlVIB ZTJPTt+osJg1DPrCfZ6ZN0LoJt/snnILlXYZyJQ69B0QOTwLje9rNiYcb9YPseYv VurWmRa+u5WTmK0tE5vSrY3OKnIFFHJ9OpK98Ip2Pjx4r5fLQSHN/5xDPY8Tt0qu Twc8GML4vF7JYbJjI9JXm0OgwG1/UVeStYrCd0+RU9p/fZtlmL7Q2T7A/z/Ty3Iv BzXt7Q7fLsmflj44yPxjO8YNoI9/h6/lJf36eJ3b8k0NqyAYHrvPHDguHRz08ILI /SjpEVSMs0BWEh7+scOQJYm8fKtlCLgrzJzJeFoB/YT4zJkkSftyjV4mVyy+tK8n oIqtE5UQMlzKa1JnzWajWgyTt3rpjS5obBEKIeKciFhG0ssJ5L7Xl/E+rXSByq5l GOI813JXLCYL45ljcxdFDQX8kgwgAJtkFD3aVwjTsyjZzR69rrxQI+1+e6PVCgU/ adIaEqEePasf5nZrLi42 =Fdy5 -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v4 00/21] OMAP UART Patches Date: Sun, 16 Sep 2012 21:36:22 +0300 Message-ID: <20120916183620.GA30189@arwen.pp.htv.fi> References: <20120906122948.GC29202@arwen.pp.htv.fi> <1346935540-1792-1-git-send-email-balbi@ti.com> <20120912062259.GC18563@arwen.pp.htv.fi> Reply-To: balbi@ti.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-serial-owner@vger.kernel.org To: Paul Walmsley Cc: Felipe Balbi , Shubhrajyoti Datta , Greg KH , alan@linux.intel.com, Tony Lindgren , Kevin Hilman , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , linux-serial@vger.kernel.org, Linux Kernel Mailing List , Santosh Shilimkar , Sourav Poddar List-Id: linux-omap@vger.kernel.org --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Sep 16, 2012 at 01:22:01AM +0000, Paul Walmsley wrote: > On Wed, 12 Sep 2012, Felipe Balbi wrote: >=20 > > On Tue, Sep 11, 2012 at 10:02:48PM +0000, Paul Walmsley wrote: > >=20 > > > The bad news is that N800 no longer boots -- or the UART dies during= =20 > > > serial init: > > >=20 > > > http://www.pwsan.com/omap/testlogs/test_tty_next_e36851d0/20120910020= 323/boot/2420n800/2420n800_log.txt > > >=20 > > > The problem doesn't seem to affect the 2430SDP. > > >=20 > > > Could you put together a patch to fix N800? >=20 > Bisected this down. It's this one that causes the problem on N800: >=20 > commit 93220dcc3052182e7156c09655ad1316055564b9 > Author: Felipe Balbi > Date: Thu Sep 6 15:45:27 2012 +0300 >=20 > serial: omap: set dev->drvdata before enabling pm_runtime > =20 > by the time we call our first pm_runtme_get_sync() > after enable pm_runtime, our resume method might > be called. To avoid problems, we must make sure > that our dev->drvdata is set correctly before > our resume method gets called. > =20 > Tested-by: Shubhrajyoti D > Acked-by: Santosh Shilimkar > Signed-off-by: Felipe Balbi > Signed-off-by: Greg Kroah-Hartman Interesting. That simply moves platform_set_drvdata() to a saner location... The only way for this to cause problems is if we're trying to restore a context which was never saved. Is there a way to prevent runtime_resume() to be called during probe() if I know the HW is already enabled ? Maybe with pm_runtime_set_active() ? --=20 balbi --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQVhwkAAoJEIaOsuA1yqREVJYP/jqYh5vUZOh5Fq/rEsortJiY baO1XAXccZhNqo8TyyEqMqMYqA+AtIrj5DROl8ZhBChsxwkKqgvHq/gaAhYMVnq5 r4LboEbQ17EkJQAIwouTVBVsRpm/IP83bNpLl1dLCIVXMjIXUx6QAXFkIae9iwa9 j9yTKzjYp7YFdmAINE6kvkoiDtrzu0qMBmUwqHklTqWGEU6xoZRG2QGXuPYWlVIB ZTJPTt+osJg1DPrCfZ6ZN0LoJt/snnILlXYZyJQ69B0QOTwLje9rNiYcb9YPseYv VurWmRa+u5WTmK0tE5vSrY3OKnIFFHJ9OpK98Ip2Pjx4r5fLQSHN/5xDPY8Tt0qu Twc8GML4vF7JYbJjI9JXm0OgwG1/UVeStYrCd0+RU9p/fZtlmL7Q2T7A/z/Ty3Iv BzXt7Q7fLsmflj44yPxjO8YNoI9/h6/lJf36eJ3b8k0NqyAYHrvPHDguHRz08ILI /SjpEVSMs0BWEh7+scOQJYm8fKtlCLgrzJzJeFoB/YT4zJkkSftyjV4mVyy+tK8n oIqtE5UQMlzKa1JnzWajWgyTt3rpjS5obBEKIeKciFhG0ssJ5L7Xl/E+rXSByq5l GOI813JXLCYL45ljcxdFDQX8kgwgAJtkFD3aVwjTsyjZzR69rrxQI+1+e6PVCgU/ adIaEqEePasf5nZrLi42 =Fdy5 -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: balbi@ti.com (Felipe Balbi) Date: Sun, 16 Sep 2012 21:36:22 +0300 Subject: [PATCH v4 00/21] OMAP UART Patches In-Reply-To: References: <20120906122948.GC29202@arwen.pp.htv.fi> <1346935540-1792-1-git-send-email-balbi@ti.com> <20120912062259.GC18563@arwen.pp.htv.fi> Message-ID: <20120916183620.GA30189@arwen.pp.htv.fi> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Sun, Sep 16, 2012 at 01:22:01AM +0000, Paul Walmsley wrote: > On Wed, 12 Sep 2012, Felipe Balbi wrote: > > > On Tue, Sep 11, 2012 at 10:02:48PM +0000, Paul Walmsley wrote: > > > > > The bad news is that N800 no longer boots -- or the UART dies during > > > serial init: > > > > > > http://www.pwsan.com/omap/testlogs/test_tty_next_e36851d0/20120910020323/boot/2420n800/2420n800_log.txt > > > > > > The problem doesn't seem to affect the 2430SDP. > > > > > > Could you put together a patch to fix N800? > > Bisected this down. It's this one that causes the problem on N800: > > commit 93220dcc3052182e7156c09655ad1316055564b9 > Author: Felipe Balbi > Date: Thu Sep 6 15:45:27 2012 +0300 > > serial: omap: set dev->drvdata before enabling pm_runtime > > by the time we call our first pm_runtme_get_sync() > after enable pm_runtime, our resume method might > be called. To avoid problems, we must make sure > that our dev->drvdata is set correctly before > our resume method gets called. > > Tested-by: Shubhrajyoti D > Acked-by: Santosh Shilimkar > Signed-off-by: Felipe Balbi > Signed-off-by: Greg Kroah-Hartman Interesting. That simply moves platform_set_drvdata() to a saner location... The only way for this to cause problems is if we're trying to restore a context which was never saved. Is there a way to prevent runtime_resume() to be called during probe() if I know the HW is already enabled ? Maybe with pm_runtime_set_active() ? -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: