From: Daniel Vetter <daniel@ffwll.ch>
To: Ian Pilcher <arequipeno@gmail.com>
Cc: "Koskipaa, Antti" <antti.koskipaa@intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: -next trees
Date: Thu, 27 Sep 2012 16:42:05 +0200 [thread overview]
Message-ID: <20120927144205.GF2098@bremse> (raw)
In-Reply-To: <50636DEB.8000704@gmail.com>
On Wed, Sep 26, 2012 at 04:04:43PM -0500, Ian Pilcher wrote:
> On 09/26/2012 12:00 PM, Adam Jackson wrote:
> >On Tue, 2012-09-25 at 13:47 -0500, Ian Pilcher wrote:
> >>
> >>1. The display (LG L246WP) is confused by *any* InfoFrames.
> >
> >If this is still the case after applying:
> >
> >commit adf00b26d18e1b3570451296e03bcb20e4798cdd
> >Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >Date: Tue Sep 25 13:23:34 2012 -0300
> >
> > drm/i915: make sure we write all the DIP data bytes
> >
> >Then I suspect I'm compelled to agree that we need a quirk to forcibly
> >disable InfoFrames entirely. I don't like to be difficult about this,
> >but the HDMI spec is quite clear that sinks _must_ accept InfoFrames
> >defined in either the CEA or HDMI specs, so if we're seeing that class
> >of failure I tend to strongly suspect our drivers first.
>
> I just tested with that patch applied, and the problem still exists, so
> consider yourself compelled.
>
> Unless you object, I will go ahead and create a patch series that does
> only:
>
> - user-defined EDID quirks
> - DISABLE_INFOFRAMES quirk
> - DISABLE_INFOFRAMES quirk for LG L246WP
>
> (I will specifically *not* address the audio issue in this series.)
>
> >>3. drm_detect_monitor_audio is returning true for the LG L246WP, which
> >> definitely doesn't have any audio capabilities. This may be a bug
> >> in the display's EDID, or it may be a parsing error.
> >
> >The display is definitely a filthy liar then:
> >
> > Audio data block
> > Linear PCM, max channels 1
> > Supported sample rates (kHz): 48 44.1 32
> > Supported sample sizes (bits): 24 20 16
> >
> >Hooray for hardware. Not sure what the logic should be for whether to
> >send HDMI audio or not, I'll re-read the appropriate scrolls.
>
> Well, if hardware didn't suck we wouldn't need quirks.
>
> If you'd like, I can generate a second patch series that adds some or
> all of:
>
> - NO_AUDIO quirk
> - drm_monitor_has_hdmi_audio() function
I've volunteered Antti from our team to implement this (and to patch up
drm/i915), so this should happen already and with the above no infoframes
quirks we shouldn't need any additional quirks.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-09-27 14:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 1:44 -next trees Dave Airlie
2012-09-13 22:10 ` Alex Deucher
2012-09-17 16:25 ` Rob Clark
2012-09-22 9:43 ` Paul Menzel
2012-09-23 4:34 ` Ian Pilcher
2012-09-24 14:34 ` Adam Jackson
2012-09-25 18:47 ` Ian Pilcher
2012-09-26 17:00 ` Adam Jackson
2012-09-26 21:04 ` Ian Pilcher
2012-09-27 14:42 ` Daniel Vetter [this message]
2012-09-28 7:03 ` [PATCH v5 0/3] Enhanced EDID quirk functionality Ian Pilcher
2012-09-28 7:03 ` [PATCH v5 1/3] drm: Add user-defined EDID quirks capability Ian Pilcher
2012-10-09 12:15 ` Jani Nikula
2012-10-09 15:13 ` Ian Pilcher
2012-10-10 6:31 ` Jani Nikula
2012-09-28 7:03 ` [PATCH v5 2/3] drm: Add EDID quirk to disable HDMI InfoFrames Ian Pilcher
2012-09-28 7:03 ` [PATCH v5 3/3] drm: Add EDID quirk for LG L246WP Ian Pilcher
2012-10-08 23:22 ` [PATCH v5 0/3] Enhanced EDID quirk functionality Ian Pilcher
2012-10-09 15:18 ` Adam Jackson
2016-09-28 3:31 -next trees Dave Airlie
2016-09-28 21:07 ` Alex Deucher
2016-09-29 9:47 ` Daniel Vetter
2016-09-29 16:23 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927144205.GF2098@bremse \
--to=daniel@ffwll.ch \
--cc=antti.koskipaa@intel.com \
--cc=arequipeno@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.