From: gmbnomis@gmail.com (Simon Baatz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: remove unnecessary flush of anon pages in flush(_kernel)_dcache_page()
Date: Thu, 27 Sep 2012 19:35:43 +0200 [thread overview]
Message-ID: <20120927173543.GA20442@schnuecks.de> (raw)
In-Reply-To: <20120927122327.GA26188@arm.com>
Hi Catalin,
On Thu, Sep 27, 2012 at 01:23:28PM +0100, Catalin Marinas wrote:
> On Wed, Sep 26, 2012 at 10:40:59PM +0100, Simon Baatz wrote:
> > On non-aliasing VIPT D-caches, there is no need to flush the kernel
> > mapping of anon pages in flush_kernel_dcache_page() and
> > flush_dcache_page() directly. If the page is mapped as executable
> > later, the necessary D/I-cache flush will be done in
> > __sync_icache_dcache().
> >
> > Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Russell King <linux@arm.linux.org.uk>
>
> I would suggest you make this patch the first one rather than
> introducing __flush_kernel_dcache_page() and subsequently replacing its
> code.
The reason for this structure is that I did not want to mix the bug
fix (which may qualify for stable) with the improvement. If I do the
patches the other way around and only the bug fix patch will be
picked for stable, flush_dcache_page() and flush_kernel_dcache_page()
will have different logic in which cases to flush. We know that the
current logic is solid, we don't have much evidence for the logic of
the proposed improvement.
>From this point of view, I find the current structure cleaner, but I
have no strong opinion about this. If we can't apply that particular
patch for stable anyway or you still think it is better the other way
around, I can change that of course.
- Simon
prev parent reply other threads:[~2012-09-27 17:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 21:40 [PATCH 0/2] fix and improvement of flush(_kernel)_dcache_page() Simon Baatz
2012-09-26 21:40 ` [PATCH V2 1/2] ARM: Handle user space mapped pages in flush_kernel_dcache_page Simon Baatz
2012-09-26 21:40 ` [PATCH 2/2] ARM: remove unnecessary flush of anon pages in flush(_kernel)_dcache_page() Simon Baatz
2012-09-27 12:23 ` Catalin Marinas
2012-09-27 17:35 ` Simon Baatz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927173543.GA20442@schnuecks.de \
--to=gmbnomis@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.