From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071Ab2I3Idz (ORCPT ); Sun, 30 Sep 2012 04:33:55 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:43414 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666Ab2I3Idt (ORCPT ); Sun, 30 Sep 2012 04:33:49 -0400 Date: Sun, 30 Sep 2012 17:25:42 +0900 From: Tejun Heo To: Glauber Costa Cc: Michal Hocko , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, devel@openvz.org, linux-mm@kvack.org, Suleiman Souhlal , Frederic Weisbecker , Mel Gorman , David Rientjes , Christoph Lameter , Pekka Enberg , Johannes Weiner Subject: Re: [PATCH v3 06/13] memcg: kmem controller infrastructure Message-ID: <20120930082542.GH10383@mtj.dyndns.org> References: <1347977050-29476-1-git-send-email-glommer@parallels.com> <1347977050-29476-7-git-send-email-glommer@parallels.com> <20120926155108.GE15801@dhcp22.suse.cz> <5064392D.5040707@parallels.com> <20120927134432.GE29104@dhcp22.suse.cz> <50658B3B.9020303@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50658B3B.9020303@parallels.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2012 at 03:34:19PM +0400, Glauber Costa wrote: > On 09/27/2012 05:44 PM, Michal Hocko wrote: > > Anyway, I have just noticed that __mem_cgroup_try_charge does > > VM_BUG_ON(css_is_removed(&memcg->css)) on a given memcg so you should > > keep css ref count up as well. > > IIRC, css_get will prevent the cgroup directory from being removed. > Because some allocations are expected to outlive the cgroup, we > specifically don't want that. That synchronous ref draining is going away. Maybe we can do that before kmemcg? Michal, do you have some timeframe on mind? Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3 06/13] memcg: kmem controller infrastructure Date: Sun, 30 Sep 2012 17:25:42 +0900 Message-ID: <20120930082542.GH10383@mtj.dyndns.org> References: <1347977050-29476-1-git-send-email-glommer@parallels.com> <1347977050-29476-7-git-send-email-glommer@parallels.com> <20120926155108.GE15801@dhcp22.suse.cz> <5064392D.5040707@parallels.com> <20120927134432.GE29104@dhcp22.suse.cz> <50658B3B.9020303@parallels.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=WXHnzzMJ0YFR4eSGlwxMgAU5hJ5SkpdcLVeDvK7fqK0=; b=URm6M37LJLP2gI9J0zDDD+Y0JvFRNEQnjsUTO+o7EElVkP/tUT+6HD755jG84ASAPC 39xVpUQ0Fj11wOprP216hVJGG6gt7vpHY+dBjylLt3tkeUYP1kbbkp0VdAetHPpEHh5+ T+Djz03AQzftMR+11ZzdzdkvEbDJhzp7S5Zj3psJBn778qxcZAjsTW3s4tJpddyuQ2Yq /FTs9hRbPrjLxBSPzCl0I/6DV9E4T1X4POnJHLgX0MojnMkvSXA2dFNTT4oVCDJQmPyn KRlFW9kY5SEpXwEZNzKT4S85SUdSr/PYgrvFvoNYQRZFq2XVdNjz8IPkEfHdK1Jnthg6 MfaA== Content-Disposition: inline In-Reply-To: <50658B3B.9020303@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Glauber Costa Cc: Michal Hocko , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, devel@openvz.org, linux-mm@kvack.org, Suleiman Souhlal , Frederic Weisbecker , Mel Gorman , David Rientjes , Christoph Lameter , Pekka Enberg , Johannes Weiner On Fri, Sep 28, 2012 at 03:34:19PM +0400, Glauber Costa wrote: > On 09/27/2012 05:44 PM, Michal Hocko wrote: > > Anyway, I have just noticed that __mem_cgroup_try_charge does > > VM_BUG_ON(css_is_removed(&memcg->css)) on a given memcg so you should > > keep css ref count up as well. > > IIRC, css_get will prevent the cgroup directory from being removed. > Because some allocations are expected to outlive the cgroup, we > specifically don't want that. That synchronous ref draining is going away. Maybe we can do that before kmemcg? Michal, do you have some timeframe on mind? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org