From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219Ab2JAKgs (ORCPT ); Mon, 1 Oct 2012 06:36:48 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:52660 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753153Ab2JAKgr (ORCPT ); Mon, 1 Oct 2012 06:36:47 -0400 Date: Mon, 1 Oct 2012 11:36:42 +0100 From: Lee Jones To: Rajanikanth HV Cc: "francescolavra.fl@gmail.com" , "arnd@arndb.de" , "anton.vorontsov@linaro.org" , Linus WALLEIJ , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-dev@lists.linaro.org" , "patches@linaro.org" , STEricsson_nomadik_linux Subject: Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge Message-ID: <20121001103642.GE6682@gmail.com> References: <1349064513-31301-1-git-send-email-rajanikanth.hv@stericsson.com> <1349064513-31301-2-git-send-email-rajanikanth.hv@stericsson.com> <20121001094929.GB6682@gmail.com> <50696991.2080103@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50696991.2080103@stericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > did you have a look at arnd and anton comments regarding > 'supplied-to' and boolean property Try to keep your comments inline, situated below the relevant comment. > >> + ab8500_battery_info: ab8500_bat_type { > >> + battery-type = <2>; > >> + thermistor-on-batctrl = <1>; > > You have this as a bool here, and ... > >> + e.g: > >> + ab8500_battery_info: ab8500_bat_type { > >> + thermistor-on-batctrl; > > ... a standard property here. I suggest you drop the bool value. I'm guessing it's just the documentation that needs amending. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 1 Oct 2012 11:36:42 +0100 Subject: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge In-Reply-To: <50696991.2080103@stericsson.com> References: <1349064513-31301-1-git-send-email-rajanikanth.hv@stericsson.com> <1349064513-31301-2-git-send-email-rajanikanth.hv@stericsson.com> <20121001094929.GB6682@gmail.com> <50696991.2080103@stericsson.com> Message-ID: <20121001103642.GE6682@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > did you have a look at arnd and anton comments regarding > 'supplied-to' and boolean property Try to keep your comments inline, situated below the relevant comment. > >> + ab8500_battery_info: ab8500_bat_type { > >> + battery-type = <2>; > >> + thermistor-on-batctrl = <1>; > > You have this as a bool here, and ... > >> + e.g: > >> + ab8500_battery_info: ab8500_bat_type { > >> + thermistor-on-batctrl; > > ... a standard property here. I suggest you drop the bool value. I'm guessing it's just the documentation that needs amending. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog