From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility Date: Wed, 3 Oct 2012 15:27:55 +0200 Message-ID: <20121003132755.GR23096@redhat.com> References: <20120930191146.GA20012@amt.cnet> <50694EC1.8060006@siemens.com> <20121001093102.GA14797@amt.cnet> <50696E9E.7030302@siemens.com> <87zk468h3y.fsf@codemonkey.ws> <506999ED.6010409@siemens.com> <20121003095532.GO23096@redhat.com> <506C1A1D.4020209@redhat.com> <506C3B7C.408@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Lucas Meneghel Rodrigues , kvm , Scott Moser , Jan Kiszka , Marcelo Tosatti , Michael Tokarev , qemu-devel , Anthony Liguori , Cole Robinson , Andreas =?utf-8?Q?F=C3=A4rber?= To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <506C3B7C.408@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On Wed, Oct 03, 2012 at 03:19:56PM +0200, Paolo Bonzini wrote: > Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: > > Yep, I did send patches with the testdev device present on qemu-kvm.git > > to qemu.git a while ago, but there were many comments on the review, I > > ended up not implementing everything that was asked and the patches were > > archived. > > > > If nobody wants to step up to port it, I'll re-read the original thread > > and will spin up new patches (and try to go through the end with it). > > Executing the KVM unittests is something that we can't afford to lose, > > so I'd say it's important on this last mile effort to get rid of qemu-kvm. > > Absolutely, IIRC the problem was that testdev did a little bit of > everything... let's see what's the functionality of testdev: > > - write (port 0xf1), can be replaced in autotest with: > -device isa-debugcon,iobase=0xf1,chardev=... > kvm-unit-tests no longer uses 0xf1 for output. It uses serial. > - exit code (port 0xf4), see this series: > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html > > - ram size (port 0xd1). If we can also patch kvm-unittests, the memory > is available in the CMOS or in fwcfg. Here is the SeaBIOS code: > > u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); > if (rs) > rs += 16 * 1024 * 1024; > else > rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) > + 1 * 1024 * 1024); > > The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. > > Paolo -- Gleb. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJOzd-0003PW-Vq for qemu-devel@nongnu.org; Wed, 03 Oct 2012 09:28:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJOzZ-0006WC-Oy for qemu-devel@nongnu.org; Wed, 03 Oct 2012 09:28:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJOzZ-0006W4-F8 for qemu-devel@nongnu.org; Wed, 03 Oct 2012 09:28:01 -0400 Date: Wed, 3 Oct 2012 15:27:55 +0200 From: Gleb Natapov Message-ID: <20121003132755.GR23096@redhat.com> References: <20120930191146.GA20012@amt.cnet> <50694EC1.8060006@siemens.com> <20121001093102.GA14797@amt.cnet> <50696E9E.7030302@siemens.com> <87zk468h3y.fsf@codemonkey.ws> <506999ED.6010409@siemens.com> <20121003095532.GO23096@redhat.com> <506C1A1D.4020209@redhat.com> <506C3B7C.408@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <506C3B7C.408@redhat.com> Subject: Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Lucas Meneghel Rodrigues , kvm , Scott Moser , Jan Kiszka , Marcelo Tosatti , Michael Tokarev , qemu-devel , Anthony Liguori , Cole Robinson , Andreas =?utf-8?Q?F=C3=A4rber?= On Wed, Oct 03, 2012 at 03:19:56PM +0200, Paolo Bonzini wrote: > Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: > > Yep, I did send patches with the testdev device present on qemu-kvm.git > > to qemu.git a while ago, but there were many comments on the review, I > > ended up not implementing everything that was asked and the patches were > > archived. > > > > If nobody wants to step up to port it, I'll re-read the original thread > > and will spin up new patches (and try to go through the end with it). > > Executing the KVM unittests is something that we can't afford to lose, > > so I'd say it's important on this last mile effort to get rid of qemu-kvm. > > Absolutely, IIRC the problem was that testdev did a little bit of > everything... let's see what's the functionality of testdev: > > - write (port 0xf1), can be replaced in autotest with: > -device isa-debugcon,iobase=0xf1,chardev=... > kvm-unit-tests no longer uses 0xf1 for output. It uses serial. > - exit code (port 0xf4), see this series: > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html > > - ram size (port 0xd1). If we can also patch kvm-unittests, the memory > is available in the CMOS or in fwcfg. Here is the SeaBIOS code: > > u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); > if (rs) > rs += 16 * 1024 * 1024; > else > rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) > + 1 * 1024 * 1024); > > The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. > > Paolo -- Gleb.