From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47697)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TJoAP-0000Mv-P6
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:20:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TJoAL-00066M-Q6
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:20:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28698)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TJoAL-00065a-7F
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:20:49 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q94GKmSH001753
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 4 Oct 2012 12:20:48 -0400
Date: Thu, 4 Oct 2012 13:21:41 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121004132141.6fbfffce@doriath.home>
In-Reply-To: <506DB64D.4030800@redhat.com>
References: <1349275025-5093-1-git-send-email-pbonzini@redhat.com>
	<1349275025-5093-2-git-send-email-pbonzini@redhat.com>
	<20121004131456.1741007c@doriath.home>
	<506DB64D.4030800@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and
	error_setg_errno
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, 04 Oct 2012 18:16:13 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 04/10/2012 18:14, Luiz Capitulino ha scritto:
> >> > +void error_set_errno(Error **errp, int os_errno, ErrorClass err_class,
> >> > +                     const char *fmt, ...)
> > 
> > The function's name makes me expect that something else is done with os_errno
>                                                      ^^^^
> 
> Why something "else"? :)

What I meant is that, it's not clear from the function's name how os_errno
is used. Actually, it gives the impression you're storing errno, but I might
be biased :)

But again, I don't have any better suggestions.