From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJqtC-00038a-Hb for qemu-devel@nongnu.org; Thu, 04 Oct 2012 15:15:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJqtA-0004HS-Ld for qemu-devel@nongnu.org; Thu, 04 Oct 2012 15:15:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJqtA-0004Fd-7m for qemu-devel@nongnu.org; Thu, 04 Oct 2012 15:15:16 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q94JFFQF030717 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 4 Oct 2012 15:15:15 -0400 Date: Thu, 4 Oct 2012 16:16:08 -0300 From: Luiz Capitulino Message-ID: <20121004161608.3d4e0029@doriath.home> In-Reply-To: <1349275025-5093-11-git-send-email-pbonzini@redhat.com> References: <1349275025-5093-1-git-send-email-pbonzini@redhat.com> <1349275025-5093-11-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/18] qemu-char: ask and print error information from qemu-sockets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Wed, 3 Oct 2012 16:36:57 +0200 Paolo Bonzini wrote: > Before: > > $ qemu-system-x86_64 -monitor tcp:localhost:6000 > (starts despite error) > > $ qemu-system-x86_64 -monitor tcp:foo.bar:12345 > getaddrinfo(foo.bar,12345): Name or service not known > chardev: opening backend "socket" failed > > $ qemu-system-x86_64 -monitor tcp:localhost:443,server=on > inet_listen_opts: bind(ipv4,127.0.0.1,443): Permission denied > inet_listen_opts: FAILED > chardev: opening backend "socket" failed > > After: > > $ x86_64-softmmu/qemu-system-x86_64 -monitor tcp:localhost:6000 > x86_64-softmmu/qemu-system-x86_64: -monitor tcp:localhost:6000: Failed to connect to socket: Connection refused > chardev: opening backend "socket" failed > > $ x86_64-softmmu/qemu-system-x86_64 -monitor tcp:foo.bar:12345 > qemu-system-x86_64: -monitor tcp:foo.bar:12345: address resolution failed for foo.bar:12345: Name or service not known > chardev: opening backend "socket" failed > > $ x86_64-softmmu/qemu-system-x86_64 -monitor tcp:localhost:443,server=on > qemu-system-x86_64: -monitor tcp:localhost:443,server=on: Failed to bind socket: Permission denied > chardev: opening backend "socket" failed > > Signed-off-by: Paolo Bonzini Reviewed-by: Luiz Capitulino > --- > qemu-char.c | 23 +++++++++++++++++------ > 1 file modificato, 17 inserzioni(+), 6 rimozioni(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 8ebd582..04b5c23 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -2097,12 +2097,13 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts) > { > CharDriverState *chr = NULL; > NetCharDriver *s = NULL; > + Error *local_err = NULL; > int fd = -1; > > chr = g_malloc0(sizeof(CharDriverState)); > s = g_malloc0(sizeof(NetCharDriver)); > > - fd = inet_dgram_opts(opts, NULL); > + fd = inet_dgram_opts(opts, &local_err); > if (fd < 0) { > fprintf(stderr, "inet_dgram_opts failed\n"); > goto return_err; > @@ -2118,6 +2119,10 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts) > return chr; > > return_err: > + if (local_err) { > + qerror_report_err(local_err); > + error_free(local_err); > + } > g_free(chr); > g_free(s); > if (fd >= 0) { > @@ -2428,6 +2433,7 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts *opts) > { > CharDriverState *chr = NULL; > TCPCharDriver *s = NULL; > + Error *local_err = NULL; > int fd = -1; > int is_listen; > int is_waitconnect; > @@ -2448,15 +2454,15 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts *opts) > > if (is_unix) { > if (is_listen) { > - fd = unix_listen_opts(opts, NULL); > + fd = unix_listen_opts(opts, &local_err); > } else { > - fd = unix_connect_opts(opts, NULL, NULL, NULL); > + fd = unix_connect_opts(opts, &local_err, NULL, NULL); > } > } else { > if (is_listen) { > - fd = inet_listen_opts(opts, 0, NULL); > + fd = inet_listen_opts(opts, 0, &local_err); > } else { > - fd = inet_connect_opts(opts, NULL, NULL, NULL); > + fd = inet_connect_opts(opts, &local_err, NULL, NULL); > } > } > if (fd < 0) { > @@ -2517,8 +2523,13 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts *opts) > return chr; > > fail: > - if (fd >= 0) > + if (local_err) { > + qerror_report_err(local_err); > + error_free(local_err); > + } > + if (fd >= 0) { > closesocket(fd); > + } > g_free(s); > g_free(chr); > return NULL;