From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 07/16] ARM: OMAP: Make plat/sram.h local to plat-omap Date: Mon, 8 Oct 2012 09:31:36 -0700 Message-ID: <20121008163136.GE3874@atomide.com> References: <20121004213950.26676.21898.stgit@muffinssi.local> <20121004220449.26676.54281.stgit@muffinssi.local> <506EE79B.8040507@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:52705 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753542Ab2JHQbn (ORCPT ); Mon, 8 Oct 2012 12:31:43 -0400 Content-Disposition: inline In-Reply-To: <506EE79B.8040507@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Jon Hunter Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org * Jon Hunter [121005 07:00]: > Hi Tony, > > On 10/04/2012 05:04 PM, Tony Lindgren wrote: > > We can move this from plat to be local to plat-omap > > for common ARM zImage support. > > > > Signed-off-by: Tony Lindgren > > --- > > arch/arm/mach-omap1/clock.c | 3 - > > arch/arm/mach-omap1/clock_data.c | 3 - > > arch/arm/mach-omap1/devices.c | 2 > > arch/arm/mach-omap1/pm.c | 3 - > > arch/arm/mach-omap2/clkt2xxx_dpllcore.c | 3 - > > arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 3 - > > arch/arm/mach-omap2/clkt34xx_dpll3m2.c | 3 - > > arch/arm/mach-omap2/io.c | 3 - > > arch/arm/mach-omap2/omap4-common.c | 4 - > > arch/arm/mach-omap2/pm24xx.c | 3 - > > arch/arm/mach-omap2/pm34xx.c | 3 - > > arch/arm/mach-omap2/sdrc.c | 2 > > arch/arm/mach-omap2/sdrc2xxx.c | 2 > > arch/arm/mach-omap2/sleep34xx.S | 2 > > arch/arm/plat-omap/common.h | 2 > > arch/arm/plat-omap/include/plat/sram.h | 105 ------------------------- > > arch/arm/plat-omap/sram.c | 1 > > arch/arm/plat-omap/sram.h | 109 +++++++++++++++++++++++++- > > 18 files changed, 130 insertions(+), 126 deletions(-) > > delete mode 100644 arch/arm/plat-omap/include/plat/sram.h > > > > diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c > > index 638f407..b15d4ee 100644 > > --- a/arch/arm/mach-omap1/clock.c > > +++ b/arch/arm/mach-omap1/clock.c > > @@ -24,11 +24,12 @@ > > #include > > #include > > #include > > -#include > > #include > > > > #include > > > > +#include "../plat-omap/sram.h" > > Any reason why you did not put this in > arch/arm/plat-omap/include/plat-omap/ like we were discussing for dma > and dmtimers headers? Then it can be just "#include ". > Just curious ... Because plat-omap/sram.h is still available for (mis)use by drivers and there's no need to expose it. Eventually our plat-omap/sram.c will be converted to be just a device driver using the common sram driver. Then it will need a local sram.h and include/platform_data/sram-omap.h for the legacy non-dt boot. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Mon, 8 Oct 2012 09:31:36 -0700 Subject: [PATCH 07/16] ARM: OMAP: Make plat/sram.h local to plat-omap In-Reply-To: <506EE79B.8040507@ti.com> References: <20121004213950.26676.21898.stgit@muffinssi.local> <20121004220449.26676.54281.stgit@muffinssi.local> <506EE79B.8040507@ti.com> Message-ID: <20121008163136.GE3874@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Jon Hunter [121005 07:00]: > Hi Tony, > > On 10/04/2012 05:04 PM, Tony Lindgren wrote: > > We can move this from plat to be local to plat-omap > > for common ARM zImage support. > > > > Signed-off-by: Tony Lindgren > > --- > > arch/arm/mach-omap1/clock.c | 3 - > > arch/arm/mach-omap1/clock_data.c | 3 - > > arch/arm/mach-omap1/devices.c | 2 > > arch/arm/mach-omap1/pm.c | 3 - > > arch/arm/mach-omap2/clkt2xxx_dpllcore.c | 3 - > > arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 3 - > > arch/arm/mach-omap2/clkt34xx_dpll3m2.c | 3 - > > arch/arm/mach-omap2/io.c | 3 - > > arch/arm/mach-omap2/omap4-common.c | 4 - > > arch/arm/mach-omap2/pm24xx.c | 3 - > > arch/arm/mach-omap2/pm34xx.c | 3 - > > arch/arm/mach-omap2/sdrc.c | 2 > > arch/arm/mach-omap2/sdrc2xxx.c | 2 > > arch/arm/mach-omap2/sleep34xx.S | 2 > > arch/arm/plat-omap/common.h | 2 > > arch/arm/plat-omap/include/plat/sram.h | 105 ------------------------- > > arch/arm/plat-omap/sram.c | 1 > > arch/arm/plat-omap/sram.h | 109 +++++++++++++++++++++++++- > > 18 files changed, 130 insertions(+), 126 deletions(-) > > delete mode 100644 arch/arm/plat-omap/include/plat/sram.h > > > > diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c > > index 638f407..b15d4ee 100644 > > --- a/arch/arm/mach-omap1/clock.c > > +++ b/arch/arm/mach-omap1/clock.c > > @@ -24,11 +24,12 @@ > > #include > > #include > > #include > > -#include > > #include > > > > #include > > > > +#include "../plat-omap/sram.h" > > Any reason why you did not put this in > arch/arm/plat-omap/include/plat-omap/ like we were discussing for dma > and dmtimers headers? Then it can be just "#include ". > Just curious ... Because plat-omap/sram.h is still available for (mis)use by drivers and there's no need to expose it. Eventually our plat-omap/sram.c will be converted to be just a device driver using the common sram driver. Then it will need a local sram.h and include/platform_data/sram-omap.h for the legacy non-dt boot. Regards, Tony