From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] yaffs2: Fix GCC 4.6 compile warnings
Date: Tue, 9 Oct 2012 14:53:32 -0700 [thread overview]
Message-ID: <20121009215332.GH1137@bill-the-cat> (raw)
In-Reply-To: <1349809693.26044.10@snotra>
On Tue, Oct 09, 2012 at 02:08:13PM -0500, Scott Wood wrote:
> On 10/09/2012 01:51:14 PM, Tom Rini wrote:
> >On Tue, Oct 09, 2012 at 01:09:22PM -0500, Scott Wood wrote:
> >> On 10/06/2012 11:59:17 AM, Albert ARIBAUD wrote:
> >> >Hi Anatolij,
> >> >
> >> >On Sat, 6 Oct 2012 11:31:03 +0200, Anatolij Gustschin
> ><agust@denx.de>
> >> >wrote:
> >> >
> >> >> Fix:
> >> >> yaffs_guts.c: In function 'yaffs_check_chunk_erased':
> >> >> yaffs_guts.c:324:6: warning: variable 'result' set but not used
> >> >> [-Wunused-but-set-variable]
> >> [snip]
> >> >Tested-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> >> >
> >> >This effectively makes VCMA9 and smdk2410 (the two boards which had
> >> >the yaffs warnings) build clean.
> >>
> >> It takes care of the warnings, but I still see this:
> >>
> >> Configuring for VCMA9 board...
> >> make: *** [u-boot] Error 139
> >
> >The linaro and ELDK 4.2, 5.2 toolchains build this fine. I would
> >suggest grabbing one of those for ARM.
>
> I'll give one of them a try, but is it expected that the compiler
> will be able to do 64/32 division without __udivdi3? Shouldn't
> yaffs2 be using lldiv() or do_div()?
Based on a very short skim, yes, yaffs2 looks to be buggy here and for
example "end_block = mtd->size / mtd->erasesize - 1;" from
yaffs_uboot_glue.c should be using mtd->erase_shift and shifting.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121009/15b543c9/attachment.pgp>
next prev parent reply other threads:[~2012-10-09 21:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 9:31 [U-Boot] [PATCH] yaffs2: Fix GCC 4.6 compile warnings Anatolij Gustschin
2012-10-06 11:02 ` [U-Boot] ELDK4.2 build failures for highbank, omap4_panda and omap4_sdp4430 (was: [PATCH] yaffs2: Fix GCC 4.6 compile warnings) Albert ARIBAUD
2012-10-06 11:34 ` Albert ARIBAUD
2012-10-08 16:35 ` Tom Rini
2012-10-09 5:46 ` [U-Boot] ELDK4.2 build failures for highbank, omap4_panda and omap4_sdp4430 R Sricharan
2012-10-09 16:59 ` Albert ARIBAUD
2012-10-07 18:22 ` [U-Boot] ELDK4.2 build failures for highbank, omap4_panda and omap4_sdp4430 (was: [PATCH] yaffs2: Fix GCC 4.6 compile warnings) Tom Rini
2012-10-06 16:59 ` [U-Boot] [PATCH] yaffs2: Fix GCC 4.6 compile warnings Albert ARIBAUD
2012-10-09 18:09 ` Scott Wood
2012-10-09 18:51 ` Tom Rini
2012-10-09 19:08 ` Scott Wood
2012-10-09 21:53 ` Tom Rini [this message]
2012-10-08 18:47 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009215332.GH1137@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.