From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 20/24] drm/i915: Allocate fbcon from stolen memory Date: Thu, 11 Oct 2012 11:54:35 -0700 Message-ID: <20121011115435.056d27df@jbarnes-desktop> References: <1346788996-19080-1-git-send-email-chris@chris-wilson.co.uk> <1346788996-19080-21-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy11-pub.bluehost.com (oproxy11-pub.bluehost.com [173.254.64.10]) by gabe.freedesktop.org (Postfix) with SMTP id 0DBA1A02DA for ; Thu, 11 Oct 2012 11:54:02 -0700 (PDT) In-Reply-To: <1346788996-19080-21-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 4 Sep 2012 21:03:12 +0100 Chris Wilson wrote: > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/intel_fb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c > index 97f6735..9de9cd9 100644 > --- a/drivers/gpu/drm/i915/intel_fb.c > +++ b/drivers/gpu/drm/i915/intel_fb.c > @@ -84,7 +84,9 @@ static int intelfb_create(struct intel_fbdev *ifbdev, > > size = mode_cmd.pitches[0] * mode_cmd.height; > size = ALIGN(size, PAGE_SIZE); > - obj = i915_gem_alloc_object(dev, size); > + obj = i915_gem_object_create_stolen(dev, size); > + if (obj == NULL) > + obj = i915_gem_alloc_object(dev, size); > if (!obj) { > DRM_ERROR("failed to allocate framebuffer\n"); > ret = -ENOMEM; Just for fun? Sounds good, may as well put it to use somehow. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center