From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] ARM: clps711x: make all virtual addresses definition via one macro
Date: Thu, 11 Oct 2012 18:24:38 +0400 [thread overview]
Message-ID: <20121011182438.abb66cce.shc_work@mail.ru> (raw)
In-Reply-To: <201210101825.49391.arnd@arndb.de>
On Wed, 10 Oct 2012 18:25:49 +0000
Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 10 October 2012, Alexander Shiyan wrote:
> > This patch make all virtual addresses definition via one macro.
> > This modification allows to avoid warning "BUG: mapping for 0x80000000
> > at 0xff000000 out of vmalloc space".
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>
> Two comments on this one:
>
> * I wonder if we could just kill off some of the mappings if no driver
> relies on the registers being mapped in advance, especially for those
> that don't benefit from section mapping like the ethernet one that is
> only a page anyway.
I'm working on this and the next series of patches will be is almost
completely free of static mappings.
> * I would recommend defining the IO_ADDRESS macro in a way that the
> result is of type 'void __iomem *', and you add a cast in the
> map_desc array. We will probably clean those up eventually and
> require that they are pointers at that place anyway, based on
> recent discussions.
It's easy to do. Will be considered in the next series of patches.
--
Alexander Shiyan <shc_work@mail.ru>
next prev parent reply other threads:[~2012-10-11 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 15:45 [PATCH 1/7] ARM: clps711x: convert to clockevents Alexander Shiyan
2012-10-10 15:45 ` [PATCH 2/7] ARM: clps711x: p720t: remove missing #include Alexander Shiyan
2012-10-10 15:45 ` [PATCH 3/7] ARM: clps711x: rework IRQ sybsustem initialization Alexander Shiyan
2012-10-10 15:45 ` [PATCH 4/7] ARM: clps711x: added missing definitions Alexander Shiyan
2012-10-10 15:45 ` [PATCH 5/7] ARM: clps711x: make all virtual addresses definition via one macro Alexander Shiyan
2012-10-10 18:25 ` Arnd Bergmann
2012-10-11 14:24 ` Alexander Shiyan [this message]
2012-10-10 15:45 ` [PATCH 6/7] ARM: clps711x: merge all CLPS711X-defconfigs into one Alexander Shiyan
2012-10-10 15:45 ` [PATCH 7/7] ARM: clps711x: merge files related to EDB7211-board " Alexander Shiyan
2012-10-10 18:30 ` [PATCH 1/7] ARM: clps711x: convert to clockevents Arnd Bergmann
2012-10-25 15:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011182438.abb66cce.shc_work@mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.