From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932837Ab2JSSd6 (ORCPT ); Fri, 19 Oct 2012 14:33:58 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:35278 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756175Ab2JSSdz (ORCPT ); Fri, 19 Oct 2012 14:33:55 -0400 Date: Fri, 19 Oct 2012 19:33:47 +0100 From: Al Viro To: Tony Luck Cc: "linux-kernel@vger.kernel.org" , Linus Torvalds , Catalin Marinas , Haavard Skinnemoen , Mike Frysinger , Jesper Nilsson , David Howells , Benjamin Herrenschmidt , Hirokazu Takata , Geert Uytterhoeven , Michal Simek , Jonas Bonn , "James E.J. Bottomley" , Richard Kuo , Martin Schwidefsky , Lennox Wu , "David S. Miller" , Paul Mundt , Chris Zankel , Chris Metcalf , Yoshinori Sato , Guan Xuetao Subject: Re: new execve/kernel_thread design Message-ID: <20121019183347.GQ2616@ZenIV.linux.org.uk> References: <20121016223508.GR2616@ZenIV.linux.org.uk> <20121019154901.GK2616@ZenIV.linux.org.uk> <3908561D78D1C84285E8C5FCA982C28F19D57A82@ORSMSX108.amr.corp.intel.com> <20121019173029.GO2616@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 19, 2012 at 11:01:53AM -0700, Tony Luck wrote: > On Fri, Oct 19, 2012 at 10:30 AM, Al Viro wrote: > > IIRC, the lack of comments on function with unusual calling conventions was > > the last remaining issue... > > Stylistically other asm functions have huge block header > comments detailing register usage. But typically those > are way more complex. I think your inline comments > work fine here. Thanks; ACKed-by and Tested-by added, branch put into no-rebase mode. So openrisc and ia64 are in the finished pile now...