From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 08/10] pinctrl: single: support pinconf generic Date: Fri, 19 Oct 2012 11:44:58 -0700 Message-ID: <20121019184458.GR4730@atomide.com> References: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> <1350551224-12857-8-git-send-email-haojian.zhuang@gmail.com> <20121018222907.GH30550@atomide.com> <20121019024012.GP30550@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20121019024012.GP30550-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Haojian Zhuang Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org * Tony Lindgren [121018 19:41]: > * Haojian Zhuang [121018 19:25]: > > > > I wonder whether gpio function in OMAP is also configured in the pinmux > > register. For example, the function is 3bit field in pinmux register > > of Marvell's > > PXA/MMP silicon. GPIO function is the one of function. > > > > If the usage case is same in OMAP silicon, I can merge > > "pinctrl-single,gpio-mask" > > with "pinctrl-single,function-mask". > > > > Do we need "pinctrl-single,gpio-disable" at here? I want to remove it, > > but I don't > > know whether it's necessary in OMAP case. > > Maybe.. I'll take a look at at that tomorrow. This one does not apply to v3.7-rc1 because of the pinctrl,bits support merged from Peter Ujfalusi. Can you please update and repost? Thanks, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 19 Oct 2012 11:44:58 -0700 Subject: [PATCH 08/10] pinctrl: single: support pinconf generic In-Reply-To: <20121019024012.GP30550@atomide.com> References: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> <1350551224-12857-8-git-send-email-haojian.zhuang@gmail.com> <20121018222907.GH30550@atomide.com> <20121019024012.GP30550@atomide.com> Message-ID: <20121019184458.GR4730@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Tony Lindgren [121018 19:41]: > * Haojian Zhuang [121018 19:25]: > > > > I wonder whether gpio function in OMAP is also configured in the pinmux > > register. For example, the function is 3bit field in pinmux register > > of Marvell's > > PXA/MMP silicon. GPIO function is the one of function. > > > > If the usage case is same in OMAP silicon, I can merge > > "pinctrl-single,gpio-mask" > > with "pinctrl-single,function-mask". > > > > Do we need "pinctrl-single,gpio-disable" at here? I want to remove it, > > but I don't > > know whether it's necessary in OMAP case. > > Maybe.. I'll take a look at at that tomorrow. This one does not apply to v3.7-rc1 because of the pinctrl,bits support merged from Peter Ujfalusi. Can you please update and repost? Thanks, Tony