From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQGtT-00036R-G2 for qemu-devel@nongnu.org; Mon, 22 Oct 2012 08:14:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQGtR-0005Mh-Uq for qemu-devel@nongnu.org; Mon, 22 Oct 2012 08:14:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQGtR-0005MG-MN for qemu-devel@nongnu.org; Mon, 22 Oct 2012 08:14:05 -0400 Date: Mon, 22 Oct 2012 15:16:01 +0200 From: "Michael S. Tsirkin" Message-ID: <20121022131601.GC16851@redhat.com> References: <20121021124303.GA5096@redhat.com> <5084E088.9090602@redhat.com> <20121022100821.GB24424@redhat.com> <508521F3.3070008@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <508521F3.3070008@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: aliguori@us.ibm.com, juzhang@redhat.com, jan.kiszka@siemens.com, Jason Baron , qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com On Mon, Oct 22, 2012 at 12:37:39PM +0200, Gerd Hoffmann wrote: > On 10/22/12 12:08, Michael S. Tsirkin wrote: > > On Mon, Oct 22, 2012 at 07:58:32AM +0200, Gerd Hoffmann wrote: > >> Hi, > >> > >>> Would it make sense to temporarily rename the machine type e.g. > >>> pc-q35-experimental to stress it's not fully supported? > >> > >> I don't think this is needed as piix will continue to be the default. > > > > Well q35 is not yet 100% ready. > > I know. > > > The point was to hide it from libvirt. > > libvirt should support pc-q35 not pc-q35-experimental, then > > it will not cause trouble. > > You'll not going to hide it that way. Libvirt will just 'qemu -M ?' > where q35 will show up even if you rename it to be postfixed -experimental. > > But as long as 'pc' continues to be the default the causal user will > never ever notice q35 is there, at least not with virt-manager (dunno > about boxes) as there is simply no gui way to pick the machine type. > You'll have to explicitly "virsh edit $guest" to switch it to q35. > > So I'm not sure what you are worryed about. I worry about need to maintain bug for bug compatibility on the unlikely chance that the work to complete it gets delayed and we release it in an unready state. > But in any case this needs > discussion with the libvirt folks to make sure it will actually work as > intended. /me tends to think a experimental bit in machine_info (which > is then printed by 'qemu -M ?' and the QOM-version of that) is more > useful than playing tricks with the name. > > cheers, > Gerd I agree it's best to ask libvirt folks what's the right way to hide a machine type from it. Add a flag so it's not listed in -M ? ? Jason, do you know? -- MST